Merge "[Ongoing Call] Remove #onEntryCleanUp override." into sc-v2-dev
This commit is contained in:
committed by
Android (Google) Code Review
commit
ea6e7bea8a
@@ -108,16 +108,7 @@ class OngoingCallController @Inject constructor(
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
// Fix for b/199600334
|
|
||||||
override fun onEntryCleanUp(entry: NotificationEntry) {
|
|
||||||
removeChipIfNeeded(entry)
|
|
||||||
}
|
|
||||||
|
|
||||||
override fun onEntryRemoved(entry: NotificationEntry, reason: Int) {
|
override fun onEntryRemoved(entry: NotificationEntry, reason: Int) {
|
||||||
removeChipIfNeeded(entry)
|
|
||||||
}
|
|
||||||
|
|
||||||
private fun removeChipIfNeeded(entry: NotificationEntry) {
|
|
||||||
if (entry.sbn.key == callNotificationInfo?.key) {
|
if (entry.sbn.key == callNotificationInfo?.key) {
|
||||||
removeChip()
|
removeChip()
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -224,18 +224,6 @@ class OngoingCallControllerTest : SysuiTestCase() {
|
|||||||
verify(mockOngoingCallListener).onOngoingCallStateChanged(anyBoolean())
|
verify(mockOngoingCallListener).onOngoingCallStateChanged(anyBoolean())
|
||||||
}
|
}
|
||||||
|
|
||||||
/** Regression test for b/201097913. */
|
|
||||||
@Test
|
|
||||||
fun onEntryCleanUp_callNotifAddedThenRemoved_listenerNotified() {
|
|
||||||
val ongoingCallNotifEntry = createOngoingCallNotifEntry()
|
|
||||||
notifCollectionListener.onEntryAdded(ongoingCallNotifEntry)
|
|
||||||
reset(mockOngoingCallListener)
|
|
||||||
|
|
||||||
notifCollectionListener.onEntryCleanUp(ongoingCallNotifEntry)
|
|
||||||
|
|
||||||
verify(mockOngoingCallListener).onOngoingCallStateChanged(anyBoolean())
|
|
||||||
}
|
|
||||||
|
|
||||||
/** Regression test for b/188491504. */
|
/** Regression test for b/188491504. */
|
||||||
@Test
|
@Test
|
||||||
fun onEntryRemoved_removedNotifHasSameKeyAsAddedNotif_listenerNotified() {
|
fun onEntryRemoved_removedNotifHasSameKeyAsAddedNotif_listenerNotified() {
|
||||||
|
|||||||
Reference in New Issue
Block a user