From 7a6cc0c006d76953760353c00048c8134c9ba294 Mon Sep 17 00:00:00 2001 From: Elliott Hughes Date: Wed, 8 May 2019 12:12:39 -0700 Subject: [PATCH] Track libziparchive API change. Bug: http://b/129068177 Test: treehugger Change-Id: Id4b202502b07e08102deda49f7d28ba10a63bb0a --- core/jni/android_util_jar_StrictJarFile.cpp | 12 ++---------- libs/androidfw/ApkAssets.cpp | 3 +-- libs/androidfw/ZipFileRO.cpp | 5 +---- 3 files changed, 4 insertions(+), 16 deletions(-) diff --git a/core/jni/android_util_jar_StrictJarFile.cpp b/core/jni/android_util_jar_StrictJarFile.cpp index a26707eedb286..e33da9167e051 100644 --- a/core/jni/android_util_jar_StrictJarFile.cpp +++ b/core/jni/android_util_jar_StrictJarFile.cpp @@ -100,16 +100,8 @@ jlong StrictJarFile_nativeStartIteration(JNIEnv* env, jobject, jlong nativeHandl } IterationHandle* handle = new IterationHandle(); - int32_t error = 0; - if (prefixChars.size() == 0) { - error = StartIteration(reinterpret_cast(nativeHandle), - handle->CookieAddress(), NULL, NULL); - } else { - ZipString entry_name(prefixChars.c_str()); - error = StartIteration(reinterpret_cast(nativeHandle), - handle->CookieAddress(), &entry_name, NULL); - } - + int32_t error = StartIteration(reinterpret_cast(nativeHandle), + handle->CookieAddress(), prefixChars.c_str(), ""); if (error) { throwIoException(env, error); return static_cast(-1); diff --git a/libs/androidfw/ApkAssets.cpp b/libs/androidfw/ApkAssets.cpp index 47b7d646d79fe..7ba7828d71c45 100644 --- a/libs/androidfw/ApkAssets.cpp +++ b/libs/androidfw/ApkAssets.cpp @@ -206,9 +206,8 @@ bool ApkAssets::ForEachFile(const std::string& root_path, root_path_full += '/'; } - ::ZipString prefix(root_path_full.c_str()); void* cookie; - if (::StartIteration(zip_handle_.get(), &cookie, &prefix, nullptr) != 0) { + if (::StartIteration(zip_handle_.get(), &cookie, root_path_full, "") != 0) { return false; } diff --git a/libs/androidfw/ZipFileRO.cpp b/libs/androidfw/ZipFileRO.cpp index 44614c11fb146..ee5f7783635d3 100644 --- a/libs/androidfw/ZipFileRO.cpp +++ b/libs/androidfw/ZipFileRO.cpp @@ -149,11 +149,8 @@ bool ZipFileRO::startIteration(void** cookie) { bool ZipFileRO::startIteration(void** cookie, const char* prefix, const char* suffix) { _ZipEntryRO* ze = new _ZipEntryRO; - ZipString pe(prefix ? prefix : ""); - ZipString se(suffix ? suffix : ""); int32_t error = StartIteration(mHandle, &(ze->cookie), - prefix ? &pe : NULL, - suffix ? &se : NULL); + prefix ? prefix : "", suffix ? suffix : ""); if (error) { ALOGW("Could not start iteration over %s: %s", mFileName != NULL ? mFileName : "", ErrorCodeString(error));