From e8ae62c0ce95703849d1e465e091dea59e2ee93a Mon Sep 17 00:00:00 2001 From: Eric Biggers Date: Fri, 4 Aug 2023 18:38:49 +0000 Subject: [PATCH] LockSettingsService: remove TODO for getCredentialTypeInternal() The TODO for getCredentialTypeInternal() was added by ag/9569544 ("Introduce Lockscreen PIN credential as first-class citizen"), which predated ag/16692269 ("Add a binder cache to ILockSettings#getCredentialType"). As the latter change effectively addressed the TODO, remove the TODO. Test: N/A Change-Id: Ia9a33053f9e0db030bfd4272c2c4318278f896a4 --- .../com/android/server/locksettings/LockSettingsService.java | 1 - 1 file changed, 1 deletion(-) diff --git a/services/core/java/com/android/server/locksettings/LockSettingsService.java b/services/core/java/com/android/server/locksettings/LockSettingsService.java index 489044f9486a8..a4d08b06d6206 100644 --- a/services/core/java/com/android/server/locksettings/LockSettingsService.java +++ b/services/core/java/com/android/server/locksettings/LockSettingsService.java @@ -1317,7 +1317,6 @@ public class LockSettingsService extends ILockSettings.Stub { return getCredentialTypeInternal(userId); } - // TODO: this is a hot path, can we optimize it? /** * Returns the credential type of the user, can be one of {@link #CREDENTIAL_TYPE_NONE}, * {@link #CREDENTIAL_TYPE_PATTERN}, {@link #CREDENTIAL_TYPE_PIN} and