From 67c134f849711c30e8cfba375b9e3c8616b4b277 Mon Sep 17 00:00:00 2001 From: Adam Lesinski Date: Fri, 10 Jun 2016 15:15:08 -0700 Subject: [PATCH] BatteryStats: Fix read/write parcel order Also moves discharge coulomb data to BATTERY_DISCHARGE_DATA checkin line. Bug:29264326 Bug:28743761 Change-Id: I78881e166c11f40b2397e04d2cab8d5200c71eea --- core/java/android/os/BatteryStats.java | 10 ++++++---- .../java/com/android/internal/os/BatteryStatsImpl.java | 6 +++--- 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/core/java/android/os/BatteryStats.java b/core/java/android/os/BatteryStats.java index 93cf8314076b6..ad8cbd83370b0 100644 --- a/core/java/android/os/BatteryStats.java +++ b/core/java/android/os/BatteryStats.java @@ -2836,8 +2836,8 @@ public abstract class BatteryStats implements Parcelable { whichBatteryRealtime / 1000, whichBatteryUptime / 1000, totalRealtime / 1000, totalUptime / 1000, getStartClockTime(), - whichBatteryScreenOffRealtime / 1000, whichBatteryScreenOffUptime / 1000, - dischargeCount / 1000, dischargeScreenOffCount / 1000); + whichBatteryScreenOffRealtime / 1000, whichBatteryScreenOffUptime / 1000); + // Calculate wakelock times across all uids. long fullWakeLockTimeTotal = 0; @@ -2987,12 +2987,14 @@ public abstract class BatteryStats implements Parcelable { dumpLine(pw, 0 /* uid */, category, BATTERY_DISCHARGE_DATA, getDischargeStartLevel()-getDischargeCurrentLevel(), getDischargeStartLevel()-getDischargeCurrentLevel(), - getDischargeAmountScreenOn(), getDischargeAmountScreenOff()); + getDischargeAmountScreenOn(), getDischargeAmountScreenOff(), + dischargeCount / 1000, dischargeScreenOffCount / 1000); } else { dumpLine(pw, 0 /* uid */, category, BATTERY_DISCHARGE_DATA, getLowDischargeAmountSinceCharge(), getHighDischargeAmountSinceCharge(), getDischargeAmountScreenOnSinceCharge(), - getDischargeAmountScreenOffSinceCharge()); + getDischargeAmountScreenOffSinceCharge(), + dischargeCount / 1000, dischargeScreenOffCount / 1000); } if (reqUid < 0) { diff --git a/core/java/com/android/internal/os/BatteryStatsImpl.java b/core/java/com/android/internal/os/BatteryStatsImpl.java index 7fb178713b95a..07d38d71b3473 100644 --- a/core/java/com/android/internal/os/BatteryStatsImpl.java +++ b/core/java/com/android/internal/os/BatteryStatsImpl.java @@ -108,7 +108,7 @@ public class BatteryStatsImpl extends BatteryStats { private static final int MAGIC = 0xBA757475; // 'BATSTATS' // Current on-disk Parcel version - private static final int VERSION = 145 + (USE_OLD_HISTORY ? 1000 : 0); + private static final int VERSION = 146 + (USE_OLD_HISTORY ? 1000 : 0); // Maximum number of items we will record in the history. private static final int MAX_HISTORY_ITEMS = 2000; @@ -10451,10 +10451,10 @@ public class BatteryStatsImpl extends BatteryStats { out.writeInt(getDischargeAmountScreenOffSinceCharge()); mDischargeStepTracker.writeToParcel(out); mChargeStepTracker.writeToParcel(out); - mDischargeCounter.writeSummaryFromParcelLocked(out); - mDischargeScreenOffCounter.writeSummaryFromParcelLocked(out); mDailyDischargeStepTracker.writeToParcel(out); mDailyChargeStepTracker.writeToParcel(out); + mDischargeCounter.writeSummaryFromParcelLocked(out); + mDischargeScreenOffCounter.writeSummaryFromParcelLocked(out); if (mDailyPackageChanges != null) { final int NPKG = mDailyPackageChanges.size(); out.writeInt(NPKG);