Move EventLogTags.writeDeviceIdle calls outside synchronized block. am: ea01439ef2

am: c2df6afdec

Change-Id: I70335305b9accb01eb09f002668bbb7dbc1eba9d
This commit is contained in:
Felipe Leme
2016-09-09 02:31:48 +00:00
committed by android-build-merger
2 changed files with 23 additions and 23 deletions

View File

@@ -2217,23 +2217,23 @@ public class NetworkPolicyManagerService extends INetworkPolicyManager.Stub {
@Override @Override
public void setDeviceIdleMode(boolean enabled) { public void setDeviceIdleMode(boolean enabled) {
mContext.enforceCallingOrSelfPermission(MANAGE_NETWORK_POLICY, TAG); mContext.enforceCallingOrSelfPermission(MANAGE_NETWORK_POLICY, TAG);
Trace.traceBegin(Trace.TRACE_TAG_NETWORK, "setDeviceIdleMode"); Trace.traceBegin(Trace.TRACE_TAG_NETWORK, "setDeviceIdleMode");
try { try {
synchronized (mUidRulesFirstLock) { synchronized (mUidRulesFirstLock) {
if (mDeviceIdleMode != enabled) { if (mDeviceIdleMode == enabled) {
mDeviceIdleMode = enabled; return;
if (mSystemReady) {
// Device idle change means we need to rebuild rules for all
// known apps, so do a global refresh.
updateRulesForRestrictPowerUL();
}
if (enabled) {
EventLogTags.writeDeviceIdleOnPhase("net");
} else {
EventLogTags.writeDeviceIdleOffPhase("net");
}
} }
mDeviceIdleMode = enabled;
if (mSystemReady) {
// Device idle change means we need to rebuild rules for all
// known apps, so do a global refresh.
updateRulesForRestrictPowerUL();
}
}
if (enabled) {
EventLogTags.writeDeviceIdleOnPhase("net");
} else {
EventLogTags.writeDeviceIdleOffPhase("net");
} }
} finally { } finally {
Trace.traceEnd(Trace.TRACE_TAG_NETWORK); Trace.traceEnd(Trace.TRACE_TAG_NETWORK);

View File

@@ -2538,18 +2538,18 @@ public final class PowerManagerService extends SystemService
boolean setDeviceIdleModeInternal(boolean enabled) { boolean setDeviceIdleModeInternal(boolean enabled) {
synchronized (mLock) { synchronized (mLock) {
if (mDeviceIdleMode != enabled) { if (mDeviceIdleMode == enabled) {
mDeviceIdleMode = enabled; return false;
updateWakeLockDisabledStatesLocked();
if (enabled) {
EventLogTags.writeDeviceIdleOnPhase("power");
} else {
EventLogTags.writeDeviceIdleOffPhase("power");
}
return true;
} }
return false; mDeviceIdleMode = enabled;
updateWakeLockDisabledStatesLocked();
} }
if (enabled) {
EventLogTags.writeDeviceIdleOnPhase("power");
} else {
EventLogTags.writeDeviceIdleOffPhase("power");
}
return true;
} }
boolean setLightDeviceIdleModeInternal(boolean enabled) { boolean setLightDeviceIdleModeInternal(boolean enabled) {