Merge "Make sure to update the manage button click listener after rotation" into tm-dev

This commit is contained in:
Mady Mellor
2022-03-25 17:03:43 +00:00
committed by Android (Google) Code Review

View File

@@ -1139,6 +1139,7 @@ public class BubbleStackView extends FrameLayout
// The menu itself should respect locale direction so the icons are on the correct side. // The menu itself should respect locale direction so the icons are on the correct side.
mManageMenu.setLayoutDirection(LAYOUT_DIRECTION_LOCALE); mManageMenu.setLayoutDirection(LAYOUT_DIRECTION_LOCALE);
addView(mManageMenu); addView(mManageMenu);
updateManageButtonListener();
} }
/** /**
@@ -1315,7 +1316,6 @@ public class BubbleStackView extends FrameLayout
/** Respond to the display size change by recalculating view size and location. */ /** Respond to the display size change by recalculating view size and location. */
public void onDisplaySizeChanged() { public void onDisplaySizeChanged() {
updateOverflow(); updateOverflow();
setUpManageMenu();
setUpFlyout(); setUpFlyout();
setUpDismissView(); setUpDismissView();
updateUserEdu(); updateUserEdu();
@@ -1344,6 +1344,7 @@ public class BubbleStackView extends FrameLayout
if (mIsExpanded) { if (mIsExpanded) {
updateExpandedView(); updateExpandedView();
} }
setUpManageMenu();
} }
@Override @Override
@@ -2814,7 +2815,7 @@ public class BubbleStackView extends FrameLayout
// a race condition with adding the BubbleExpandedView view to the expanded view // a race condition with adding the BubbleExpandedView view to the expanded view
// container. Due to the race condition the click handler sometimes is not set up // container. Due to the race condition the click handler sometimes is not set up
// correctly and is never called. // correctly and is never called.
bev.setManageClickListener((view) -> showManageMenu(true /* show */)); updateManageButtonListener();
}, 0); }, 0);
if (!mIsExpansionAnimating) { if (!mIsExpansionAnimating) {
@@ -2825,6 +2826,16 @@ public class BubbleStackView extends FrameLayout
} }
} }
private void updateManageButtonListener() {
if (mIsExpanded && mExpandedBubble != null
&& mExpandedBubble.getExpandedView() != null) {
BubbleExpandedView bev = mExpandedBubble.getExpandedView();
bev.setManageClickListener((view) -> {
showManageMenu(true /* show */);
});
}
}
/** /**
* Requests a snapshot from the currently expanded bubble's TaskView and displays it in a * Requests a snapshot from the currently expanded bubble's TaskView and displays it in a
* SurfaceView. This allows us to load a newly expanded bubble's Activity into the TaskView, * SurfaceView. This allows us to load a newly expanded bubble's Activity into the TaskView,