From e85e8e7cd35d1bdce604f5d698ee245283516a38 Mon Sep 17 00:00:00 2001 From: Rambo Wang Date: Thu, 6 Feb 2020 18:05:42 -0800 Subject: [PATCH] Update javadoc of deprecated UICC APIs b/146360599 is used to deprecate some UICC APIs but leaving TODO comments as the replacement APIs in SeureElement is not ready. With SecureElement APIs settle down, the javadocs are updated to link to specific replacement APIs. Bug: 148981423 Test: make offline-sdk-docs Change-Id: I5646ea25daa514023f808a0abc4065b85e55d4ef --- .../android/telephony/TelephonyManager.java | 85 ++++++++++++------- 1 file changed, 55 insertions(+), 30 deletions(-) diff --git a/telephony/java/android/telephony/TelephonyManager.java b/telephony/java/android/telephony/TelephonyManager.java index 0042ec8e2117a..6a680a9ac5505 100644 --- a/telephony/java/android/telephony/TelephonyManager.java +++ b/telephony/java/android/telephony/TelephonyManager.java @@ -6023,9 +6023,11 @@ public class TelephonyManager { * @param AID Application id. See ETSI 102.221 and 101.220. * @param p2 P2 parameter (described in ISO 7816-4). * @return an IccOpenLogicalChannelResponse object. - * @deprecated Use {@link android.se.omapi.SEService} APIs instead. + * @deprecated Use {@link android.se.omapi.SEService} APIs instead. See + * {@link android.se.omapi.SEService#getUiccReader(int)}, + * {@link android.se.omapi.Reader#openSession()}, + * {@link android.se.omapi.Session#openLogicalChannel(byte[], byte)}. */ - // TODO(b/147153909): Update Javadoc to link to specific SEService API once integrated. @Deprecated public IccOpenLogicalChannelResponse iccOpenLogicalChannel(String AID, int p2) { return iccOpenLogicalChannel(getSubId(), AID, p2); @@ -6057,9 +6059,11 @@ public class TelephonyManager { * @param p2 P2 parameter (described in ISO 7816-4). * @return an IccOpenLogicalChannelResponse object. * @hide - * @deprecated Use {@link android.se.omapi.SEService} APIs instead. + * @deprecated Use {@link android.se.omapi.SEService} APIs instead. See + * {@link android.se.omapi.SEService#getUiccReader(int)}, + * {@link android.se.omapi.Reader#openSession()}, + * {@link android.se.omapi.Session#openLogicalChannel(byte[], byte)}. */ - // TODO(b/147153909): Update Javadoc to link to specific SEService API once integrated. @Deprecated public IccOpenLogicalChannelResponse iccOpenLogicalChannel(int subId, String AID, int p2) { try { @@ -6088,9 +6092,9 @@ public class TelephonyManager { * iccOpenLogicalChannel. * @return true if the channel was closed successfully. * @hide - * @deprecated Use {@link android.se.omapi.SEService} APIs instead. + * @deprecated Use {@link android.se.omapi.SEService} APIs instead. See + * {@link android.se.omapi.Channel#close()}. */ - // TODO(b/147153909): Update Javadoc to link to specific SEService API once integrated. @Deprecated @RequiresPermission(Manifest.permission.MODIFY_PHONE_STATE) @SystemApi @@ -6118,9 +6122,9 @@ public class TelephonyManager { * @param channel is the channel id to be closed as returned by a successful * iccOpenLogicalChannel. * @return true if the channel was closed successfully. - * @deprecated Use {@link android.se.omapi.SEService} APIs instead. + * @deprecated Use {@link android.se.omapi.SEService} APIs instead. See + * {@link android.se.omapi.Channel#close()}. */ - // TODO(b/147153909): Update Javadoc to link to specific SEService API once integrated. @Deprecated public boolean iccCloseLogicalChannel(int channel) { return iccCloseLogicalChannel(getSubId(), channel); @@ -6140,9 +6144,9 @@ public class TelephonyManager { * iccOpenLogicalChannel. * @return true if the channel was closed successfully. * @hide - * @deprecated Use {@link android.se.omapi.SEService} APIs instead. + * @deprecated Use {@link android.se.omapi.SEService} APIs instead. See + * {@link android.se.omapi.Channel#close()}. */ - // TODO(b/147153909): Update Javadoc to link to specific SEService API once integrated. @Deprecated public boolean iccCloseLogicalChannel(int subId, int channel) { try { @@ -6179,9 +6183,9 @@ public class TelephonyManager { * @return The APDU response from the ICC card with the status appended at the end, or null if * there is an issue connecting to the Telephony service. * @hide - * @deprecated Use {@link android.se.omapi.SEService} APIs instead. + * @deprecated Use {@link android.se.omapi.SEService} APIs instead. See + * {@link android.se.omapi.Channel#transmit(byte[])}. */ - // TODO(b/147153909): Update Javadoc to link to specific SEService API once integrated. @Deprecated @RequiresPermission(Manifest.permission.MODIFY_PHONE_STATE) @SystemApi @@ -6220,9 +6224,9 @@ public class TelephonyManager { * @param data Data to be sent with the APDU. * @return The APDU response from the ICC card with the status appended at * the end. - * @deprecated Use {@link android.se.omapi.SEService} APIs instead. + * @deprecated Use {@link android.se.omapi.SEService} APIs instead. See + * {@link android.se.omapi.Channel#transmit(byte[])}. */ - // TODO(b/147153909): Update Javadoc to link to specific SEService API once integrated. @Deprecated public String iccTransmitApduLogicalChannel(int channel, int cla, int instruction, int p1, int p2, int p3, String data) { @@ -6252,9 +6256,9 @@ public class TelephonyManager { * @return The APDU response from the ICC card with the status appended at * the end. * @hide - * @deprecated Use {@link android.se.omapi.SEService} APIs instead. + * @deprecated Use {@link android.se.omapi.SEService} APIs instead. See + * {@link android.se.omapi.Channel#transmit(byte[])}. */ - // TODO(b/147153909): Update Javadoc to link to specific SEService API once integrated. @Deprecated public String iccTransmitApduLogicalChannel(int subId, int channel, int cla, int instruction, int p1, int p2, int p3, String data) { @@ -6291,9 +6295,12 @@ public class TelephonyManager { * @return The APDU response from the ICC card with the status appended at * the end. * @hide - * @deprecated Use {@link android.se.omapi.SEService} APIs instead. + * @deprecated Use {@link android.se.omapi.SEService} APIs instead. See + * {@link android.se.omapi.SEService#getUiccReader(int)}, + * {@link android.se.omapi.Reader#openSession()}, + * {@link android.se.omapi.Session#openBasicChannel(byte[], byte)}, + * {@link android.se.omapi.Channel#transmit(byte[])}. */ - // TODO(b/147153909): Update Javadoc to link to specific SEService API once integrated. @Deprecated @RequiresPermission(Manifest.permission.MODIFY_PHONE_STATE) @SystemApi @@ -6330,9 +6337,12 @@ public class TelephonyManager { * @param data Data to be sent with the APDU. * @return The APDU response from the ICC card with the status appended at * the end. - * @deprecated Use {@link android.se.omapi.SEService} APIs instead. + * @deprecated Use {@link android.se.omapi.SEService} APIs instead. See + * {@link android.se.omapi.SEService#getUiccReader(int)}, + * {@link android.se.omapi.Reader#openSession()}, + * {@link android.se.omapi.Session#openBasicChannel(byte[], byte)}, + * {@link android.se.omapi.Channel#transmit(byte[])}. */ - // TODO(b/147153909): Update Javadoc to link to specific SEService API once integrated. @Deprecated public String iccTransmitApduBasicChannel(int cla, int instruction, int p1, int p2, int p3, String data) { @@ -6360,9 +6370,12 @@ public class TelephonyManager { * @return The APDU response from the ICC card with the status appended at * the end. * @hide - * @deprecated Use {@link android.se.omapi.SEService} APIs instead. + * @deprecated Use {@link android.se.omapi.SEService} APIs instead. See + * {@link android.se.omapi.SEService#getUiccReader(int)}, + * {@link android.se.omapi.Reader#openSession()}, + * {@link android.se.omapi.Session#openBasicChannel(byte[], byte)}, + * {@link android.se.omapi.Channel#transmit(byte[])}. */ - // TODO(b/147153909): Update Javadoc to link to specific SEService API once integrated. @Deprecated public String iccTransmitApduBasicChannel(int subId, int cla, int instruction, int p1, int p2, int p3, String data) { @@ -6391,9 +6404,12 @@ public class TelephonyManager { * @param p3 P3 value of the APDU command. * @param filePath * @return The APDU response. - * @deprecated Use {@link android.se.omapi.SEService} APIs instead. + * @deprecated Use {@link android.se.omapi.SEService} APIs instead. See + * {@link android.se.omapi.SEService#getUiccReader(int)}, + * {@link android.se.omapi.Reader#openSession()}, + * {@link android.se.omapi.Session#openBasicChannel(byte[], byte)}, + * {@link android.se.omapi.Channel#transmit(byte[])}. */ - // TODO(b/147153909): Update Javadoc to link to specific SEService API once integrated. @Deprecated public byte[] iccExchangeSimIO(int fileID, int command, int p1, int p2, int p3, String filePath) { @@ -6416,9 +6432,12 @@ public class TelephonyManager { * @param filePath * @return The APDU response. * @hide - * @deprecated Use {@link android.se.omapi.SEService} APIs instead. + * @deprecated Use {@link android.se.omapi.SEService} APIs instead. See + * {@link android.se.omapi.SEService#getUiccReader(int)}, + * {@link android.se.omapi.Reader#openSession()}, + * {@link android.se.omapi.Session#openBasicChannel(byte[], byte)}, + * {@link android.se.omapi.Channel#transmit(byte[])}. */ - // TODO(b/147153909): Update Javadoc to link to specific SEService API once integrated. @Deprecated public byte[] iccExchangeSimIO(int subId, int fileID, int command, int p1, int p2, int p3, String filePath) { @@ -6445,9 +6464,12 @@ public class TelephonyManager { * @return The APDU response from the ICC card in hexadecimal format * with the last 4 bytes being the status word. If the command fails, * returns an empty string. - * @deprecated Use {@link android.se.omapi.SEService} APIs instead. + * @deprecated Use {@link android.se.omapi.SEService} APIs instead. See + * {@link android.se.omapi.SEService#getUiccReader(int)}, + * {@link android.se.omapi.Reader#openSession()}, + * {@link android.se.omapi.Session#openBasicChannel(byte[], byte)}, + * {@link android.se.omapi.Channel#transmit(byte[])}. */ - // TODO(b/147153909): Update Javadoc to link to specific SEService API once integrated. @Deprecated public String sendEnvelopeWithStatus(String content) { return sendEnvelopeWithStatus(getSubId(), content); @@ -6468,9 +6490,12 @@ public class TelephonyManager { * with the last 4 bytes being the status word. If the command fails, * returns an empty string. * @hide - * @deprecated Use {@link android.se.omapi.SEService} APIs instead. + * @deprecated Use {@link android.se.omapi.SEService} APIs instead. See + * {@link android.se.omapi.SEService#getUiccReader(int)}, + * {@link android.se.omapi.Reader#openSession()}, + * {@link android.se.omapi.Session#openBasicChannel(byte[], byte)}, + * {@link android.se.omapi.Channel#transmit(byte[])}. */ - // TODO(b/147153909): Update Javadoc to link to specific SEService API once integrated. @Deprecated public String sendEnvelopeWithStatus(int subId, String content) { try {