Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Binder: small failed transactions can be due to size"

Browse Source
This commit is contained in:
Steven Moreland
2022-02-04 18:34:00 +00:00
committed by Gerrit Code Review
parent c9a39b3066 fa462e8c44
commit e7f547a5df
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
core/jni/android_util_Binder.cpp
View File

@@ -873,7 +873,7 @@ void signalExceptionForError(JNIEnv* env, jobject obj, status_t err,
const char* exceptionToThrow; const char* exceptionToThrow;
char msg[128]; char msg[128];
// TransactionTooLargeException is a checked exception, only throw from certain methods. // TransactionTooLargeException is a checked exception, only throw from certain methods.
// FIXME: Transaction too large is the most common reason for FAILED_TRANSACTION // TODO(b/28321379): Transaction size is the most common cause for FAILED_TRANSACTION
// but it is not the only one. The Binder driver can return BR_FAILED_REPLY // but it is not the only one. The Binder driver can return BR_FAILED_REPLY
// for other reasons also, such as if the transaction is malformed or // for other reasons also, such as if the transaction is malformed or
// refers to an FD that has been closed. We should change the driver // refers to an FD that has been closed. We should change the driver
@@ -890,8 +890,9 @@ void signalExceptionForError(JNIEnv* env, jobject obj, status_t err,
exceptionToThrow = (canThrowRemoteException) exceptionToThrow = (canThrowRemoteException)
? "android/os/DeadObjectException" ? "android/os/DeadObjectException"
: "java/lang/RuntimeException"; : "java/lang/RuntimeException";
snprintf(msg, sizeof(msg)-1, snprintf(msg, sizeof(msg) - 1,
"Transaction failed on small parcel; remote process probably died"); "Transaction failed on small parcel; remote process probably died, but "
"this could also be caused by running out of binder buffer space");
} }
jniThrowException(env, exceptionToThrow, msg); jniThrowException(env, exceptionToThrow, msg);
} break; } break;