From e7d87a4e256e9c9c12e5af8b88b8a00ea9d86140 Mon Sep 17 00:00:00 2001 From: Caitlin Shkuratov Date: Wed, 8 Mar 2023 15:45:28 +0000 Subject: [PATCH] [Chipbar] Update the colors to make the chipbar stand out more. Bug: 267821684 Test: Trigger chipbar -> see new colors (screenshots in bug) Test: Change theme while chipbar is displayed -> verify chipbar is re-displayed in the new theme color Change-Id: I86ff54f931d63f5d8d44e85a8b1f1a4e7c238171 --- packages/SystemUI/res/drawable/chipbar_background.xml | 2 +- .../SystemUI/res/drawable/chipbar_end_button_background.xml | 2 +- packages/SystemUI/res/layout/chipbar.xml | 6 +++--- packages/SystemUI/res/values/colors.xml | 1 + .../temporarydisplay/TemporaryViewDisplayController.kt | 4 ++++ 5 files changed, 10 insertions(+), 5 deletions(-) diff --git a/packages/SystemUI/res/drawable/chipbar_background.xml b/packages/SystemUI/res/drawable/chipbar_background.xml index 3abf4d72c5386..57221776a32ff 100644 --- a/packages/SystemUI/res/drawable/chipbar_background.xml +++ b/packages/SystemUI/res/drawable/chipbar_background.xml @@ -17,6 +17,6 @@ - + diff --git a/packages/SystemUI/res/drawable/chipbar_end_button_background.xml b/packages/SystemUI/res/drawable/chipbar_end_button_background.xml index 3e2e4f055b14e..80c7207a35b61 100644 --- a/packages/SystemUI/res/drawable/chipbar_end_button_background.xml +++ b/packages/SystemUI/res/drawable/chipbar_end_button_background.xml @@ -20,7 +20,7 @@ android:color="?android:textColorPrimary"> - + diff --git a/packages/SystemUI/res/layout/chipbar.xml b/packages/SystemUI/res/layout/chipbar.xml index 9d26657a45352..a3171784903f8 100644 --- a/packages/SystemUI/res/layout/chipbar.xml +++ b/packages/SystemUI/res/layout/chipbar.xml @@ -55,7 +55,7 @@ android:layout_height="wrap_content" android:layout_weight="1" android:textSize="@dimen/chipbar_text_size" - android:textColor="?android:attr/textColorPrimary" + android:textColor="@android:color/system_accent2_900" android:alpha="0.0" /> @@ -66,7 +66,7 @@ android:layout_height="@dimen/chipbar_end_icon_size" android:layout_marginStart="@dimen/chipbar_end_item_start_margin" android:src="@drawable/ic_progress_activity" - android:tint="?androidprv:attr/colorAccentPrimaryVariant" + android:tint="@android:color/system_accent2_700" android:alpha="0.0" /> @@ -76,7 +76,7 @@ android:layout_height="@dimen/chipbar_end_icon_size" android:layout_marginStart="@dimen/chipbar_end_item_start_margin" android:src="@drawable/ic_warning" - android:tint="@color/GM2_red_500" + android:tint="@color/GM2_red_600" android:alpha="0.0" /> diff --git a/packages/SystemUI/res/values/colors.xml b/packages/SystemUI/res/values/colors.xml index ca4217f64b600..285017c014b11 100644 --- a/packages/SystemUI/res/values/colors.xml +++ b/packages/SystemUI/res/values/colors.xml @@ -161,6 +161,7 @@ #F28B82 #EA4335 + #B3261E #C5221F #8AB4F8 diff --git a/packages/SystemUI/src/com/android/systemui/temporarydisplay/TemporaryViewDisplayController.kt b/packages/SystemUI/src/com/android/systemui/temporarydisplay/TemporaryViewDisplayController.kt index 1065d3349930d..c6cb79a6a8802 100644 --- a/packages/SystemUI/src/com/android/systemui/temporarydisplay/TemporaryViewDisplayController.kt +++ b/packages/SystemUI/src/com/android/systemui/temporarydisplay/TemporaryViewDisplayController.kt @@ -294,6 +294,10 @@ abstract class TemporaryViewDisplayController