Merge "Rename caption resources for Desktop mode." into tm-qpr-dev am: 65e129f2eb

Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/20841287

Change-Id: Ib66f45eaf3bb497bf8ea49ee138c804cff3221fd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
This commit is contained in:
Merissa Mitchell
2023-01-04 04:32:45 +00:00
committed by Automerger Merge Worker
8 changed files with 13 additions and 12 deletions

View File

@@ -20,7 +20,7 @@ android:id="@+id/handle_menu"
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:gravity="center_horizontal" android:gravity="center_horizontal"
android:background="@drawable/decor_caption_menu_background"> android:background="@drawable/desktop_mode_decor_menu_background">
<Button <Button
style="@style/CaptionButtonStyle" style="@style/CaptionButtonStyle"
android:id="@+id/fullscreen_button" android:id="@+id/fullscreen_button"

View File

@@ -16,10 +16,10 @@
--> -->
<com.android.wm.shell.windowdecor.WindowDecorLinearLayout <com.android.wm.shell.windowdecor.WindowDecorLinearLayout
xmlns:android="http://schemas.android.com/apk/res/android" xmlns:android="http://schemas.android.com/apk/res/android"
android:id="@+id/caption" android:id="@+id/desktop_mode_caption"
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:background="@drawable/decor_caption_title"> android:background="@drawable/desktop_mode_decor_title">
<Button <Button
style="@style/CaptionButtonStyle" style="@style/CaptionButtonStyle"
android:id="@+id/back_button" android:id="@+id/back_button"

View File

@@ -282,7 +282,7 @@ public class DesktopModeWindowDecorViewModel implements WindowDecorViewModel {
public boolean onTouch(View v, MotionEvent e) { public boolean onTouch(View v, MotionEvent e) {
boolean isDrag = false; boolean isDrag = false;
int id = v.getId(); int id = v.getId();
if (id != R.id.caption_handle && id != R.id.caption) { if (id != R.id.caption_handle && id != R.id.desktop_mode_caption) {
return false; return false;
} }
if (id == R.id.caption_handle) { if (id == R.id.caption_handle) {

View File

@@ -132,7 +132,7 @@ public class DesktopModeWindowDecoration extends WindowDecoration<WindowDecorLin
mRelayoutParams.reset(); mRelayoutParams.reset();
mRelayoutParams.mRunningTaskInfo = taskInfo; mRelayoutParams.mRunningTaskInfo = taskInfo;
mRelayoutParams.mLayoutResId = R.layout.caption_window_decoration; mRelayoutParams.mLayoutResId = R.layout.desktop_mode_window_decor;
mRelayoutParams.mCaptionHeightId = R.dimen.freeform_decor_caption_height; mRelayoutParams.mCaptionHeightId = R.dimen.freeform_decor_caption_height;
mRelayoutParams.mCaptionWidthId = R.dimen.freeform_decor_caption_width; mRelayoutParams.mCaptionWidthId = R.dimen.freeform_decor_caption_width;
mRelayoutParams.mShadowRadiusId = shadowRadiusID; mRelayoutParams.mShadowRadiusId = shadowRadiusID;
@@ -212,7 +212,7 @@ public class DesktopModeWindowDecoration extends WindowDecoration<WindowDecorLin
* Sets up listeners when a new root view is created. * Sets up listeners when a new root view is created.
*/ */
private void setupRootView() { private void setupRootView() {
View caption = mResult.mRootView.findViewById(R.id.caption); View caption = mResult.mRootView.findViewById(R.id.desktop_mode_caption);
caption.setOnTouchListener(mOnCaptionTouchListener); caption.setOnTouchListener(mOnCaptionTouchListener);
View close = caption.findViewById(R.id.close_window); View close = caption.findViewById(R.id.close_window);
close.setOnClickListener(mOnCaptionButtonClickListener); close.setOnClickListener(mOnCaptionButtonClickListener);
@@ -243,7 +243,7 @@ public class DesktopModeWindowDecoration extends WindowDecoration<WindowDecorLin
*/ */
private void setCaptionVisibility(boolean visible) { private void setCaptionVisibility(boolean visible) {
int v = visible ? View.VISIBLE : View.GONE; int v = visible ? View.VISIBLE : View.GONE;
View captionView = mResult.mRootView.findViewById(R.id.caption); View captionView = mResult.mRootView.findViewById(R.id.desktop_mode_caption);
captionView.setVisibility(v); captionView.setVisibility(v);
if (!visible) closeHandleMenu(); if (!visible) closeHandleMenu();
} }
@@ -265,7 +265,7 @@ public class DesktopModeWindowDecoration extends WindowDecoration<WindowDecorLin
*/ */
void setButtonVisibility(boolean visible) { void setButtonVisibility(boolean visible) {
int visibility = visible ? View.VISIBLE : View.GONE; int visibility = visible ? View.VISIBLE : View.GONE;
View caption = mResult.mRootView.findViewById(R.id.caption); View caption = mResult.mRootView.findViewById(R.id.desktop_mode_caption);
View back = caption.findViewById(R.id.back_button); View back = caption.findViewById(R.id.back_button);
View close = caption.findViewById(R.id.close_window); View close = caption.findViewById(R.id.close_window);
back.setVisibility(visibility); back.setVisibility(visibility);
@@ -304,7 +304,7 @@ public class DesktopModeWindowDecoration extends WindowDecoration<WindowDecorLin
int width = loadDimensionPixelSize(resources, mRelayoutParams.mCaptionWidthId); int width = loadDimensionPixelSize(resources, mRelayoutParams.mCaptionWidthId);
int height = loadDimensionPixelSize(resources, mRelayoutParams.mCaptionHeightId); int height = loadDimensionPixelSize(resources, mRelayoutParams.mCaptionHeightId);
String namePrefix = "Caption Menu"; String namePrefix = "Caption Menu";
mHandleMenu = addWindow(R.layout.caption_handle_menu, namePrefix, t, mHandleMenu = addWindow(R.layout.desktop_mode_decor_handle_menu, namePrefix, t,
x - mResult.mDecorContainerOffsetX, y - mResult.mDecorContainerOffsetY, x - mResult.mDecorContainerOffsetX, y - mResult.mDecorContainerOffsetY,
width, height); width, height);
mSyncQueue.runInSync(transaction -> { mSyncQueue.runInSync(transaction -> {
@@ -336,7 +336,7 @@ public class DesktopModeWindowDecoration extends WindowDecoration<WindowDecorLin
*/ */
void closeHandleMenuIfNeeded(MotionEvent ev) { void closeHandleMenuIfNeeded(MotionEvent ev) {
if (isHandleMenuActive()) { if (isHandleMenuActive()) {
if (!checkEventInCaptionView(ev, R.id.caption)) { if (!checkEventInCaptionView(ev, R.id.desktop_mode_caption)) {
closeHandleMenu(); closeHandleMenu();
} }
} }
@@ -389,7 +389,7 @@ public class DesktopModeWindowDecoration extends WindowDecoration<WindowDecorLin
*/ */
void checkClickEvent(MotionEvent ev) { void checkClickEvent(MotionEvent ev) {
if (mResult.mRootView == null) return; if (mResult.mRootView == null) return;
View caption = mResult.mRootView.findViewById(R.id.caption); View caption = mResult.mRootView.findViewById(R.id.desktop_mode_caption);
PointF inputPoint = offsetCaptionLocation(ev); PointF inputPoint = offsetCaptionLocation(ev);
if (!isHandleMenuActive()) { if (!isHandleMenuActive()) {
View handle = caption.findViewById(R.id.caption_handle); View handle = caption.findViewById(R.id.caption_handle);

View File

@@ -560,7 +560,8 @@ public class WindowDecorationTests extends ShellTestCase {
int height = loadDimensionPixelSize(resources, mRelayoutParams.mCaptionHeightId); int height = loadDimensionPixelSize(resources, mRelayoutParams.mCaptionHeightId);
String name = "Test Window"; String name = "Test Window";
WindowDecoration.AdditionalWindow additionalWindow = WindowDecoration.AdditionalWindow additionalWindow =
addWindow(R.layout.caption_handle_menu, name, mMockSurfaceControlAddWindowT, addWindow(R.layout.desktop_mode_decor_handle_menu, name,
mMockSurfaceControlAddWindowT,
x - mRelayoutResult.mDecorContainerOffsetX, x - mRelayoutResult.mDecorContainerOffsetX,
y - mRelayoutResult.mDecorContainerOffsetY, y - mRelayoutResult.mDecorContainerOffsetY,
width, height); width, height);