From d51eab2cb4b47bb9631c0decc98284c3060abf90 Mon Sep 17 00:00:00 2001 From: Ming-Shin Lu Date: Wed, 29 Mar 2023 12:11:38 +0000 Subject: [PATCH] Deflake CloseImeOnDismissPopupDialogTest In imeLayerAndImeSnapshotVisibleOnScreen, add "isOptional = true" when verifying IME snapshot isVisible, in case a false alarm flakiness happens when the IME snapshot surface removed when the popup editor dialog was dismissed. Bug: 274653385 Test: atest FlickerTests:CloseImeOnDismissPopupDialogTest --rerun-until-falure 10 passed on cuttlefish devices. Change-Id: I61bf11a5b63b5a540e3693f33253b2a599c2142d --- .../server/wm/flicker/ime/CloseImeOnDismissPopupDialogTest.kt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/FlickerTests/src/com/android/server/wm/flicker/ime/CloseImeOnDismissPopupDialogTest.kt b/tests/FlickerTests/src/com/android/server/wm/flicker/ime/CloseImeOnDismissPopupDialogTest.kt index d72f5288d4d55..6066d2e742098 100644 --- a/tests/FlickerTests/src/com/android/server/wm/flicker/ime/CloseImeOnDismissPopupDialogTest.kt +++ b/tests/FlickerTests/src/com/android/server/wm/flicker/ime/CloseImeOnDismissPopupDialogTest.kt @@ -66,7 +66,7 @@ open class CloseImeOnDismissPopupDialogTest(flicker: FlickerTest) : BaseTest(fli flicker.assertLayers { this.isVisible(ComponentNameMatcher.IME) .then() - .isVisible(ComponentNameMatcher.IME_SNAPSHOT) + .isVisible(ComponentNameMatcher.IME_SNAPSHOT, isOptional = true) .then() .isInvisible(ComponentNameMatcher.IME_SNAPSHOT, isOptional = true) .isInvisible(ComponentNameMatcher.IME)