Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Update the string on how to exit pinning mode in gesture navigation" into qt-qpr1-dev

Browse Source
This commit is contained in:
TreeHugger Robot
2019-08-16 01:59:02 +00:00
committed by Android (Google) Code Review
parent 5d7d213c29 98d0858138
commit e6c9ed5f90
3 changed files with 11 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
packages/SystemUI/res/values/strings.xml
View File

@@ -1386,6 +1386,8 @@
buttons</string>
<string name="screen_pinning_toast_recents_invisible">To unpin this screen, touch &amp; hold Back
and Home buttons</string>
<!-- Notify (in toast) user how to unpin screen in gesture navigation mode [CHAR LIMIT=NONE] -->
<string name="screen_pinning_toast_gesture_nav">To unpin this screen, swipe up &amp; hold</string>
<!-- Screen pinning positive response. -->
<string name="screen_pinning_positive">Got it</string>
<!-- Screen pinning negative response. -->

4
packages/SystemUI/src/com/android/systemui/statusbar/phone/NavigationBarView.java
View File

@@ -17,6 +17,7 @@
package com.android.systemui.statusbar.phone;
import static android.view.WindowManagerPolicyConstants.NAV_BAR_MODE_3BUTTON;
import static android.view.WindowManagerPolicyConstants.NAV_BAR_MODE_GESTURAL;
import static com.android.systemui.shared.system.QuickStepContract.SYSUI_STATE_HOME_DISABLED;
import static com.android.systemui.shared.system.QuickStepContract.SYSUI_STATE_NOTIFICATION_PANEL_EXPANDED;
@@ -920,7 +921,8 @@ public class NavigationBarView extends FrameLayout implements
}
public void showPinningEscapeToast() {
mScreenPinningNotify.showEscapeToast(isRecentsButtonVisible());
mScreenPinningNotify.showEscapeToast(
mNavBarMode == NAV_BAR_MODE_GESTURAL, isRecentsButtonVisible());
}
public boolean isVertical() {

10
packages/SystemUI/src/com/android/systemui/statusbar/phone/ScreenPinningNotify.java
View File

@@ -51,7 +51,7 @@ public class ScreenPinningNotify {
}
/** Show a toast that describes the gesture the user should use to escape pinned mode. */
public void showEscapeToast(boolean isRecentsButtonVisible) {
public void showEscapeToast(boolean isGestureNavEnabled, boolean isRecentsButtonVisible) {
long showToastTime = SystemClock.elapsedRealtime();
if ((showToastTime - mLastShowToastTime) < SHOW_TOAST_MINIMUM_INTERVAL) {
Slog.i(TAG, "Ignore toast since it is requested in very short interval.");
@@ -60,9 +60,11 @@ public class ScreenPinningNotify {
if (mLastToast != null) {
mLastToast.cancel();
}
mLastToast = makeAllUserToastAndShow(isRecentsButtonVisible
? R.string.screen_pinning_toast
: R.string.screen_pinning_toast_recents_invisible);
mLastToast = makeAllUserToastAndShow(isGestureNavEnabled
? R.string.screen_pinning_toast_gesture_nav
: isRecentsButtonVisible
? R.string.screen_pinning_toast
: R.string.screen_pinning_toast_recents_invisible);
mLastShowToastTime = showToastTime;
}