Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "[NMS] Call isServiceTokenValidLocked with lock."

Browse Source
This commit is contained in:
Julia Reynolds
2022-07-26 10:55:03 +00:00
committed by Gerrit Code Review
parent 6e1ac19115 5d7808a0c2
commit e672a9336d
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
services/core/java/com/android/server/notification/NotificationManagerService.java
View File

@@ -9404,10 +9404,16 @@ public class NotificationManagerService extends SystemService {
* given NAS is bound in. * given NAS is bound in.
*/ */
private boolean isInteractionVisibleToListener(ManagedServiceInfo info, int userId) { private boolean isInteractionVisibleToListener(ManagedServiceInfo info, int userId) {
boolean isAssistantService = mAssistants.isServiceTokenValidLocked(info.service); boolean isAssistantService = isServiceTokenValid(info.service);
return !isAssistantService || info.isSameUser(userId); return !isAssistantService || info.isSameUser(userId);
} }
private boolean isServiceTokenValid(IInterface service) {
synchronized (mNotificationLock) {
return mAssistants.isServiceTokenValidLocked(service);
}
}
private boolean isPackageSuspendedForUser(String pkg, int uid) { private boolean isPackageSuspendedForUser(String pkg, int uid) {
final long identity = Binder.clearCallingIdentity(); final long identity = Binder.clearCallingIdentity();
int userId = UserHandle.getUserId(uid); int userId = UserHandle.getUserId(uid);
@@ -10652,7 +10658,7 @@ public class NotificationManagerService extends SystemService {
BackgroundThread.getHandler().post(() -> { BackgroundThread.getHandler().post(() -> {
if (info.isSystem if (info.isSystem
|| hasCompanionDevice(info) || hasCompanionDevice(info)
|| mAssistants.isServiceTokenValidLocked(info.service)) { || isServiceTokenValid(info.service)) {
notifyNotificationChannelChanged( notifyNotificationChannelChanged(
info, pkg, user, channel, modificationType); info, pkg, user, channel, modificationType);
} }