From e577232406649450a513140bf09cb3fc8c3fe046 Mon Sep 17 00:00:00 2001 From: Andy McFadden Date: Fri, 22 Jan 2010 07:23:31 -0800 Subject: [PATCH] Move VM feature strings (used by DDMS) into VM. Until now, we used a place-holder in frameworks/base. Disable a test that shouldn't have been on. --- core/java/android/ddm/DdmHandleHello.java | 6 ++---- core/java/android/os/Debug.java | 11 +++++++++++ 2 files changed, 13 insertions(+), 4 deletions(-) diff --git a/core/java/android/ddm/DdmHandleHello.java b/core/java/android/ddm/DdmHandleHello.java index 0603ca5801e9a..714a6116d6ba2 100644 --- a/core/java/android/ddm/DdmHandleHello.java +++ b/core/java/android/ddm/DdmHandleHello.java @@ -56,7 +56,7 @@ public class DdmHandleHello extends ChunkHandler { if (Config.LOGV) Log.v("ddm-hello", "Connected!"); - if (true) { + if (false) { /* test spontaneous transmission */ byte[] data = new byte[] { 0, 1, 2, 3, 4, -4, -3, -2, -1, 127 }; Chunk testChunk = @@ -148,9 +148,7 @@ public class DdmHandleHello extends ChunkHandler { private Chunk handleFEAT(Chunk request) { // TODO: query the VM to ensure that support for these features // is actually compiled in - final String[] features = { - "hprof-heap-dump", "method-trace-profiling" - }; + final String[] features = Debug.getVmFeatureList(); if (Config.LOGV) Log.v("ddm-heap", "Got feature list request"); diff --git a/core/java/android/os/Debug.java b/core/java/android/os/Debug.java index b33e8be4e7457..7043c2e575a66 100644 --- a/core/java/android/os/Debug.java +++ b/core/java/android/os/Debug.java @@ -263,6 +263,17 @@ public final class Debug return VMDebug.isDebuggerConnected(); } + /** + * Returns an array of strings that identify VM features. This is + * used by DDMS to determine what sorts of operations the VM can + * perform. + * + * @hide + */ + public static String[] getVmFeatureList() { + return VMDebug.getVmFeatureList(); + } + /** * Change the JDWP port. *