From c86564b0e3c0c48747048ee0eedd7f4db3cccd26 Mon Sep 17 00:00:00 2001 From: Jorge Gil Date: Thu, 16 Feb 2023 00:21:53 +0000 Subject: [PATCH] Dispose of TaskResizeInputEventReceiver when needed Fixes a resource leak caused by the DragResizeInputListener ctor creating an InputEventReceiver and never disposing of it when the listener is closed. Bug: 269431952 Test: manual - enter desktop mode, resize freeform task, make it full screen and close it. Wait a couple of minutes and verify no StrictMode violation are reported in the logcat Change-Id: Ia1ee47d1ba55665fb5dc6116893435e189a3be26 --- .../android/wm/shell/windowdecor/DragResizeInputListener.java | 1 + 1 file changed, 1 insertion(+) diff --git a/libs/WindowManager/Shell/src/com/android/wm/shell/windowdecor/DragResizeInputListener.java b/libs/WindowManager/Shell/src/com/android/wm/shell/windowdecor/DragResizeInputListener.java index 7d954ad922851..81c4176b0f398 100644 --- a/libs/WindowManager/Shell/src/com/android/wm/shell/windowdecor/DragResizeInputListener.java +++ b/libs/WindowManager/Shell/src/com/android/wm/shell/windowdecor/DragResizeInputListener.java @@ -215,6 +215,7 @@ class DragResizeInputListener implements AutoCloseable { @Override public void close() { + mInputEventReceiver.dispose(); mInputChannel.dispose(); try { mWindowSession.remove(mFakeWindow);