Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix a11y read-twice bug

Browse Source 
Also remove a hardcoded string

Test: manual with talkback
Fixes: 133731969
Change-Id: I0effe046fd6edddd109335a6dd7fa6b732587d64
This commit is contained in:
Julia Reynolds
2019-05-31 11:22:06 -04:00
parent eb05a18d3b
commit e50aa221bc
2 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
packages/SystemUI/src/com/android/systemui/statusbar/notification/row/ChannelEditorDialogController.kt
View File

@@ -223,6 +223,8 @@ class ChannelEditorDialogController @Inject constructor(
dialog = Dialog(context) dialog = Dialog(context)
dialog.window?.requestFeature(Window.FEATURE_NO_TITLE) dialog.window?.requestFeature(Window.FEATURE_NO_TITLE)
// Prevent a11y readers from reading the first element in the dialog twice
dialog.setTitle("\u00A0")
dialog.apply { dialog.apply {
setContentView(R.layout.notif_half_shelf) setContentView(R.layout.notif_half_shelf)
setCanceledOnTouchOutside(true) setCanceledOnTouchOutside(true)

2
packages/SystemUI/src/com/android/systemui/statusbar/notification/row/ChannelEditorListView.kt
View File

@@ -143,7 +143,7 @@ class ChannelRow(c: Context, attrs: AttributeSet) : LinearLayout(c, attrs) {
private fun updateViews() { private fun updateViews() {
val nc = channel ?: return val nc = channel ?: return
channelName.text = nc.name ?: "(missing)" channelName.text = nc.name ?: ""
nc.group?.let { groupId -> nc.group?.let { groupId ->
channelDescription.text = controller.groupNameForId(groupId) channelDescription.text = controller.groupNameForId(groupId)