Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Deprecate FileUtils.closeQuietly"

Browse Source
This commit is contained in:
Treehugger Robot
2019-11-22 23:52:41 +00:00
committed by Gerrit Code Review
parent bad5a30d4f 219e986e29
commit e4b84f3475
2 changed files with 14 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
api/current.txt
View File

@@ -34540,8 +34540,8 @@ package android.os {
} }
public final class FileUtils { public final class FileUtils {
method public static void closeQuietly(@Nullable AutoCloseable); method @Deprecated public static void closeQuietly(@Nullable AutoCloseable);
method public static void closeQuietly(@Nullable java.io.FileDescriptor); method @Deprecated public static void closeQuietly(@Nullable java.io.FileDescriptor);
method public static long copy(@NonNull java.io.InputStream, @NonNull java.io.OutputStream) throws java.io.IOException; method public static long copy(@NonNull java.io.InputStream, @NonNull java.io.OutputStream) throws java.io.IOException;
method public static long copy(@NonNull java.io.InputStream, @NonNull java.io.OutputStream, @Nullable android.os.CancellationSignal, @Nullable java.util.concurrent.Executor, @Nullable android.os.FileUtils.ProgressListener) throws java.io.IOException; method public static long copy(@NonNull java.io.InputStream, @NonNull java.io.OutputStream, @Nullable android.os.CancellationSignal, @Nullable java.util.concurrent.Executor, @Nullable android.os.FileUtils.ProgressListener) throws java.io.IOException;
method public static long copy(@NonNull java.io.FileDescriptor, @NonNull java.io.FileDescriptor) throws java.io.IOException; method public static long copy(@NonNull java.io.FileDescriptor, @NonNull java.io.FileDescriptor) throws java.io.IOException;

12
core/java/android/os/FileUtils.java
View File

@@ -1275,7 +1275,13 @@ public final class FileUtils {
/** /**
* Closes the given object quietly, ignoring any checked exceptions. Does * Closes the given object quietly, ignoring any checked exceptions. Does
* nothing if the given object is {@code null}. * nothing if the given object is {@code null}.
*
* @deprecated This method may suppress potentially significant exceptions, particularly when
* closing writable resources. With a writable resource, a failure thrown from {@code close()}
* should be considered as significant as a failure thrown from a write method because it may
* indicate a failure to flush bytes to the underlying resource.
*/ */
@Deprecated
public static void closeQuietly(@Nullable AutoCloseable closeable) { public static void closeQuietly(@Nullable AutoCloseable closeable) {
IoUtils.closeQuietly(closeable); IoUtils.closeQuietly(closeable);
} }
@@ -1283,7 +1289,13 @@ public final class FileUtils {
/** /**
* Closes the given object quietly, ignoring any checked exceptions. Does * Closes the given object quietly, ignoring any checked exceptions. Does
* nothing if the given object is {@code null}. * nothing if the given object is {@code null}.
*
* @deprecated This method may suppress potentially significant exceptions, particularly when
* closing writable resources. With a writable resource, a failure thrown from {@code close()}
* should be considered as significant as a failure thrown from a write method because it may
* indicate a failure to flush bytes to the underlying resource.
*/ */
@Deprecated
public static void closeQuietly(@Nullable FileDescriptor fd) { public static void closeQuietly(@Nullable FileDescriptor fd) {
IoUtils.closeQuietly(fd); IoUtils.closeQuietly(fd);
} }