From 5ead731c57aab8044cc49acbbba25b7a3b1bc686 Mon Sep 17 00:00:00 2001 From: Tomasz Wasilczyk Date: Fri, 23 Sep 2022 21:42:58 +0000 Subject: [PATCH] Annotate KeyStore service as never null Bug: 245258360 Change-Id: I4d9215486df275012dad495730ce0ff00839b7a6 Test: TH --- keystore/java/android/security/KeyStore2.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/keystore/java/android/security/KeyStore2.java b/keystore/java/android/security/KeyStore2.java index c2cd6ffc622cf..f507d76d9e5c5 100644 --- a/keystore/java/android/security/KeyStore2.java +++ b/keystore/java/android/security/KeyStore2.java @@ -32,6 +32,7 @@ import android.system.keystore2.ResponseCode; import android.util.Log; import java.util.Calendar; +import java.util.Objects; /** * @hide This should not be made public in its present form because it @@ -137,13 +138,13 @@ public class KeyStore2 { return new KeyStore2(); } - private synchronized IKeystoreService getService(boolean retryLookup) { + @NonNull private synchronized IKeystoreService getService(boolean retryLookup) { if (mBinder == null || retryLookup) { mBinder = IKeystoreService.Stub.asInterface(ServiceManager .getService(KEYSTORE2_SERVICE_NAME)); Binder.allowBlocking(mBinder.asBinder()); } - return mBinder; + return Objects.requireNonNull(mBinder); } void delete(KeyDescriptor descriptor) throws KeyStoreException {