From 836efade0c24ec235fe3470198509f5040655642 Mon Sep 17 00:00:00 2001 From: Brad Ebinger Date: Tue, 18 Oct 2016 13:48:17 -0700 Subject: [PATCH] Adds registerSessionListener API to Log Adds the registerSessionListener API to android.telecom.Log to allow callbacks to occur when a session has been fully completed. CP from internal branch. Test: Manual Testing Bug: 26571395 Change-Id: I70ebd6f432768a5d7bd8f3a0997b8e0ef335bb35 --- telecomm/java/android/telecom/Log.java | 4 ++++ telecomm/java/android/telecom/Logging/EventManager.java | 2 -- telecomm/java/android/telecom/Logging/SessionManager.java | 1 - 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/telecomm/java/android/telecom/Log.java b/telecomm/java/android/telecom/Log.java index ecda3cd45f736..01af76b4ce4e3 100644 --- a/telecomm/java/android/telecom/Log.java +++ b/telecomm/java/android/telecom/Log.java @@ -199,6 +199,10 @@ public class Log { getSessionManager().endSession(); } + public static void registerSessionListener(SessionManager.ISessionListener l) { + getSessionManager().registerSessionListener(l); + } + public static String getSessionId() { // If the Session logger has not been initialized, then there have been no sessions logged. // Don't load it now! diff --git a/telecomm/java/android/telecom/Logging/EventManager.java b/telecomm/java/android/telecom/Logging/EventManager.java index 0849804fde6d7..4b4061907f6df 100644 --- a/telecomm/java/android/telecom/Logging/EventManager.java +++ b/telecomm/java/android/telecom/Logging/EventManager.java @@ -366,8 +366,6 @@ public class EventManager { // Now add a new entry mEventRecords.add(newRecord); mCallEventRecordMap.put(recordEntry, newRecord); - - // TODO: Add Implementation of this in Telecom for Analytics synchronized (mSync) { for (EventListener l : mEventListeners) { l.eventRecordAdded(newRecord); diff --git a/telecomm/java/android/telecom/Logging/SessionManager.java b/telecomm/java/android/telecom/Logging/SessionManager.java index 90daee01bebd2..add12374136a2 100644 --- a/telecomm/java/android/telecom/Logging/SessionManager.java +++ b/telecomm/java/android/telecom/Logging/SessionManager.java @@ -273,7 +273,6 @@ public class SessionManager { System.currentTimeMillis() - subsession.getExecutionStartTimeMilliseconds(); android.util.Slog.d(LOGGING_TAG, Session.END_SESSION + " (dur: " + fullSessionTimeMs + " ms): " + subsession.toString()); - // TODO: Add analytics hook for (ISessionListener l : mSessionListeners) { l.sessionComplete(subsession.getShortMethodName(), fullSessionTimeMs); }