From 77cac05f7df830e45215fd5221d780574513b4eb Mon Sep 17 00:00:00 2001 From: yyalan Date: Thu, 16 Feb 2023 20:34:33 +0000 Subject: [PATCH] Talkback read unlocked split shade as QS Handling the special case that in unlocked split shade, though QS is expanded, we want to call it "QS & notification shade" Fixes: 267830416 Test: manual Change-Id: I82e9076d2057171d436ceb5e60c370df69a80bf3 --- packages/SystemUI/res/values/strings.xml | 2 ++ .../systemui/shade/NotificationPanelViewController.java | 7 ++++++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/packages/SystemUI/res/values/strings.xml b/packages/SystemUI/res/values/strings.xml index e6ac59e6b1067..464ce0333fd15 100644 --- a/packages/SystemUI/res/values/strings.xml +++ b/packages/SystemUI/res/values/strings.xml @@ -479,6 +479,8 @@ Notification shade. Quick settings. + + Quick settings and Notification shade. Lock screen. diff --git a/packages/SystemUI/src/com/android/systemui/shade/NotificationPanelViewController.java b/packages/SystemUI/src/com/android/systemui/shade/NotificationPanelViewController.java index 1259f5eed87ae..2175a3358396f 100644 --- a/packages/SystemUI/src/com/android/systemui/shade/NotificationPanelViewController.java +++ b/packages/SystemUI/src/com/android/systemui/shade/NotificationPanelViewController.java @@ -2206,7 +2206,12 @@ public final class NotificationPanelViewController implements Dumpable { && mQsController.getFullyExpanded()) { // Upon initialisation when we are not layouted yet we don't want to announce that we // are fully expanded, hence the != 0.0f check. - return mResources.getString(R.string.accessibility_desc_quick_settings); + if (mSplitShadeEnabled) { + // In split shade, QS is expanded but it also shows notifications + return mResources.getString(R.string.accessibility_desc_qs_notification_shade); + } else { + return mResources.getString(R.string.accessibility_desc_quick_settings); + } } else if (mBarState == KEYGUARD) { return mResources.getString(R.string.accessibility_desc_lock_screen); } else {