Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Cancel side auth on power press

Browse Source 
Test: atest FingerprintAuthenticationClienTest
Test: Verified fingerprint hal is now sent cancellation signal.
Fixes: 258101086
Change-Id: I4b2f5ea1f7fe94b62071fb51b53224b1ca5756d0
This commit is contained in:
Joshua McCloskey
2022-11-08 19:32:18 +00:00
committed by Joshua Mccloskey
parent bbf1115856
commit e37ac35236
2 changed files with 18 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
services/core/java/com/android/server/biometrics/sensors/fingerprint/aidl/FingerprintAuthenticationClient.java
View File

@@ -94,6 +94,7 @@ class FingerprintAuthenticationClient extends AuthenticationClient<AidlSession>
private long mSideFpsLastAcquireStartTime;
private Runnable mAuthSuccessRunnable;
private final Clock mClock;
private boolean mDidFinishSfps;
FingerprintAuthenticationClient(
@NonNull Context context,
@@ -203,8 +204,9 @@ class FingerprintAuthenticationClient extends AuthenticationClient<AidlSession>
@Override
protected void handleLifecycleAfterAuth(boolean authenticated) {
if (authenticated) {
if (authenticated && !mDidFinishSfps) {
mCallback.onClientFinished(this, true /* success */);
mDidFinishSfps = true;
}
}
@@ -504,12 +506,16 @@ class FingerprintAuthenticationClient extends AuthenticationClient<AidlSession>
if (mSensorProps.isAnySidefpsType()) {
Slog.i(TAG, "(sideFPS): onPowerPressed");
mHandler.post(() -> {
if (mDidFinishSfps) {
return;
}
Slog.i(TAG, "(sideFPS): finishing auth");
// Ignore auths after a power has been detected
mHandler.removeMessages(MESSAGE_AUTH_SUCCESS);
// Do not call onError() as that will send an additional callback to coex.
onErrorInternal(BiometricConstants.BIOMETRIC_ERROR_POWER_PRESSED,
0, true);
mDidFinishSfps = true;
onErrorInternal(BiometricConstants.BIOMETRIC_ERROR_POWER_PRESSED, 0, true);
stopHalOperation();
mSensorOverlays.hide(getSensorId());
});
}

11
services/tests/servicestests/src/com/android/server/biometrics/sensors/fingerprint/aidl/FingerprintAuthenticationClientTest.java
View File

@@ -373,6 +373,7 @@ public class FingerprintAuthenticationClientTest {
@Test
public void fingerprintPowerIgnoresAuthInWindow() throws Exception {
when(mSensorProps.isAnySidefpsType()).thenReturn(true);
when(mHal.authenticate(anyLong())).thenReturn(mCancellationSignal);
final FingerprintAuthenticationClient client = createClient(1);
client.start(mCallback);
@@ -383,11 +384,13 @@ public class FingerprintAuthenticationClientTest {
mLooper.dispatchAll();
verify(mCallback).onClientFinished(any(), eq(false));
verify(mCancellationSignal).cancel();
}
@Test
public void fingerprintAuthIgnoredWaitingForPower() throws Exception {
when(mSensorProps.isAnySidefpsType()).thenReturn(true);
when(mHal.authenticate(anyLong())).thenReturn(mCancellationSignal);
final FingerprintAuthenticationClient client = createClient(1);
client.start(mCallback);
@@ -398,11 +401,13 @@ public class FingerprintAuthenticationClientTest {
mLooper.dispatchAll();
verify(mCallback).onClientFinished(any(), eq(false));
verify(mCancellationSignal).cancel();
}
@Test
public void fingerprintAuthSucceedsAfterPowerWindow() throws Exception {
public void fingerprintAuthFailsWhenAuthAfterPower() throws Exception {
when(mSensorProps.isAnySidefpsType()).thenReturn(true);
when(mHal.authenticate(anyLong())).thenReturn(mCancellationSignal);
final FingerprintAuthenticationClient client = createClient(1);
client.start(mCallback);
@@ -416,7 +421,9 @@ public class FingerprintAuthenticationClientTest {
mLooper.moveTimeForward(1000);
mLooper.dispatchAll();
verify(mCallback).onClientFinished(any(), eq(true));
verify(mCallback, never()).onClientFinished(any(), eq(true));
verify(mCallback).onClientFinished(any(), eq(false));
when(mHal.authenticateWithContext(anyLong(), any())).thenReturn(mCancellationSignal);
}
@Test