From 587ecb3a1ea3c88aee0ef984c83f158c4b0fbe81 Mon Sep 17 00:00:00 2001 From: markchien Date: Wed, 18 Mar 2020 08:43:07 +0800 Subject: [PATCH] Expose netId by adding getter API Bug: 151156820 Test: m atest TetetheringTests Change-Id: Ieb1483c146aa2f7d8f251157e6e81d71c44ae899 (cherry picked from commit 8831c4b54178753013d568c0b76bbf7487db8122) --- api/system-current.txt | 2 +- api/test-current.txt | 1 + core/java/android/net/Network.java | 13 ++++++++++++- .../server/connectivity/tethering/Tethering.java | 2 +- 4 files changed, 15 insertions(+), 3 deletions(-) diff --git a/api/system-current.txt b/api/system-current.txt index 2d2ebcde1010e..923538d24c8e4 100755 --- a/api/system-current.txt +++ b/api/system-current.txt @@ -6270,8 +6270,8 @@ package android.net { public class Network implements android.os.Parcelable { ctor public Network(@NonNull android.net.Network); + method public int getNetId(); method @NonNull public android.net.Network getPrivateDnsBypassingCopy(); - field public final int netId; } public abstract class NetworkAgent { diff --git a/api/test-current.txt b/api/test-current.txt index 286408dbbecb0..c89ee1f7422a5 100644 --- a/api/test-current.txt +++ b/api/test-current.txt @@ -1819,6 +1819,7 @@ package android.net { public class Network implements android.os.Parcelable { ctor public Network(@NonNull android.net.Network); + method public int getNetId(); method @NonNull public android.net.Network getPrivateDnsBypassingCopy(); } diff --git a/core/java/android/net/Network.java b/core/java/android/net/Network.java index 6f5471baa7abd..f807a4968d725 100644 --- a/core/java/android/net/Network.java +++ b/core/java/android/net/Network.java @@ -64,7 +64,7 @@ public class Network implements Parcelable { * The unique id of the network. * @hide */ - @SystemApi + @UnsupportedAppUsage public final int netId; // Objects used to perform per-network operations such as getSocketFactory @@ -169,6 +169,17 @@ public class Network implements Parcelable { return new Network(netId, true); } + /** + * Get the unique id of the network. + * + * @hide + */ + @TestApi + @SystemApi + public int getNetId() { + return netId; + } + /** * Returns a netid marked with the Private DNS bypass flag. * diff --git a/packages/Tethering/src/com/android/server/connectivity/tethering/Tethering.java b/packages/Tethering/src/com/android/server/connectivity/tethering/Tethering.java index 3d8dbab7d4fb6..3d25e5453dc9c 100644 --- a/packages/Tethering/src/com/android/server/connectivity/tethering/Tethering.java +++ b/packages/Tethering/src/com/android/server/connectivity/tethering/Tethering.java @@ -1458,7 +1458,7 @@ public class Tethering { } else { dnsServers = mConfig.defaultIPv4DNS; } - final int netId = (network != null) ? network.netId : NETID_UNSET; + final int netId = (network != null) ? network.getNetId() : NETID_UNSET; try { mNetd.tetherDnsSet(netId, dnsServers); mLog.log(String.format(