From ed6913b0ce99784188713975218dcff113a3d4a7 Mon Sep 17 00:00:00 2001 From: Selim Cinek Date: Wed, 1 Jun 2016 12:01:17 -0700 Subject: [PATCH] Fixed a crash with notification groups When updating a notification we were not checking if it is the summary with children, but about the existence of the childrencontainer, which can change and is never removed. This is now done correctly. Change-Id: Ie3838613f414d7fcb158dc92c24e8939cfb7c2ea Fixes: 29055879 --- .../systemui/statusbar/ExpandableNotificationRow.java | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/packages/SystemUI/src/com/android/systemui/statusbar/ExpandableNotificationRow.java b/packages/SystemUI/src/com/android/systemui/statusbar/ExpandableNotificationRow.java index c53ab5902dec0..b27e1e8acbb9c 100644 --- a/packages/SystemUI/src/com/android/systemui/statusbar/ExpandableNotificationRow.java +++ b/packages/SystemUI/src/com/android/systemui/statusbar/ExpandableNotificationRow.java @@ -18,9 +18,7 @@ package com.android.systemui.statusbar; import android.animation.Animator; import android.animation.AnimatorListenerAdapter; -import android.animation.AnimatorSet; import android.animation.ObjectAnimator; -import android.animation.ValueAnimator; import android.animation.ValueAnimator.AnimatorUpdateListener; import android.content.Context; import android.graphics.drawable.AnimatedVectorDrawable; @@ -1067,7 +1065,7 @@ public class ExpandableNotificationRow extends ActivatableNotificationView { mIsSystemExpanded = expand; notifyHeightChanged(false /* needsAnimation */); logExpansionEvent(false, wasExpanded); - if (mChildrenContainer != null) { + if (mIsSummaryWithChildren) { mChildrenContainer.updateGroupOverflow(); } } @@ -1142,7 +1140,7 @@ public class ExpandableNotificationRow extends ActivatableNotificationView { } public void updateChildrenHeaderAppearance() { - if (mChildrenContainer != null) { + if (mIsSummaryWithChildren) { mChildrenContainer.updateChildrenHeaderAppearance(); } }