From 4929a5d3b434a6915d64e449b234b40b8eff9993 Mon Sep 17 00:00:00 2001 From: Rubin Xu Date: Mon, 23 Jan 2017 23:55:28 +0000 Subject: [PATCH] Fix NPE in LockPatternUtils mDevicePolicyManager field can be null if getDevicePolicyManager() is never called. A previous refactor removed an apparent unused call to getDevicePolicyManager(), leading to NPE when mDevicePolicyManager is accessed. We should always use getDevicePolicyManager() to access DevicePolicyManager instance. Test: manual Bug: 34612758 Change-Id: Ic964b4ee4e3c56301295b8f0629bd005c732c5c4 --- core/java/com/android/internal/widget/LockPatternUtils.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/java/com/android/internal/widget/LockPatternUtils.java b/core/java/com/android/internal/widget/LockPatternUtils.java index a43f3a72782ca..9bb6fff753db8 100644 --- a/core/java/com/android/internal/widget/LockPatternUtils.java +++ b/core/java/com/android/internal/widget/LockPatternUtils.java @@ -1310,7 +1310,7 @@ public class LockPatternUtils { } private boolean isDoNotAskCredentialsOnBootSet() { - return mDevicePolicyManager.getDoNotAskCredentialsOnBoot(); + return getDevicePolicyManager().getDoNotAskCredentialsOnBoot(); } private boolean shouldEncryptWithCredentials(boolean defaultValue) {