From e18d46a6343d1260ed866f5c8d5d144cd2d31cbd Mon Sep 17 00:00:00 2001 From: shawnlin Date: Tue, 12 Mar 2019 11:48:10 +0800 Subject: [PATCH] Fixed text of manage notification button for a11y is confusing Add "manage notification" content description string for a11y. Fixes: 127877031 Test: manual Change-Id: I6fc84693a8d72071c2b46412e48a159dfd395dd9 --- packages/SystemUI/res/layout/status_bar_notification_footer.xml | 1 + packages/SystemUI/res/values/strings.xml | 2 ++ .../android/systemui/statusbar/notification/row/FooterView.java | 2 ++ 3 files changed, 5 insertions(+) diff --git a/packages/SystemUI/res/layout/status_bar_notification_footer.xml b/packages/SystemUI/res/layout/status_bar_notification_footer.xml index 056f16a936266..174a3b8e004b6 100644 --- a/packages/SystemUI/res/layout/status_bar_notification_footer.xml +++ b/packages/SystemUI/res/layout/status_bar_notification_footer.xml @@ -33,6 +33,7 @@ android:layout_height="wrap_content" android:layout_gravity="start" android:focusable="true" + android:contentDescription="@string/accessibility_manage_notification" android:text="@string/manage_notifications_text" android:textColor="?attr/wallpaperTextColor" android:textAllCaps="false"/> diff --git a/packages/SystemUI/res/values/strings.xml b/packages/SystemUI/res/values/strings.xml index 9e9aada07bef0..4e9407488dcf5 100644 --- a/packages/SystemUI/res/values/strings.xml +++ b/packages/SystemUI/res/values/strings.xml @@ -266,6 +266,8 @@ Scanning face Send + + Manage notifications unlock diff --git a/packages/SystemUI/src/com/android/systemui/statusbar/notification/row/FooterView.java b/packages/SystemUI/src/com/android/systemui/statusbar/notification/row/FooterView.java index 311bf7a244c11..c2da517772109 100644 --- a/packages/SystemUI/src/com/android/systemui/statusbar/notification/row/FooterView.java +++ b/packages/SystemUI/src/com/android/systemui/statusbar/notification/row/FooterView.java @@ -79,6 +79,8 @@ public class FooterView extends StackScrollerDecorView { mDismissButton.setContentDescription( mContext.getString(R.string.accessibility_clear_all)); mManageButton.setText(R.string.manage_notifications_text); + mManageButton.setContentDescription( + mContext.getString(R.string.accessibility_manage_notification)); } public boolean isButtonVisible() {