From e12c8f5de3154110a3ead9112f65b3327fa0083f Mon Sep 17 00:00:00 2001 From: Issei Suzuki Date: Wed, 8 Jun 2022 10:27:31 +0000 Subject: [PATCH] Clear ActivityRecord#mDismissKeyguard flag after app launches. This flag is used by the SysUI to dismiss an insecure keyguard when an app is launched from an insecure lock screen. The flag should only affect the app launch once, so needs to be cleared once the flag is processed. Bug: 234583880 Test: atest KeyguardTests#testDismissKeyguard_fromActivityOption_onlyOnce Change-Id: Ia4179b40de7d45b2199b175a6dcc24016dfba091 (cherry picked from commit 41cbf49af7d5fc18afa5a734ce69df679b0f13a9) --- services/core/java/com/android/server/wm/ActivityRecord.java | 1 - services/core/java/com/android/server/wm/KeyguardController.java | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/services/core/java/com/android/server/wm/ActivityRecord.java b/services/core/java/com/android/server/wm/ActivityRecord.java index 0d6591ca2ca36..4f222a4f8b833 100644 --- a/services/core/java/com/android/server/wm/ActivityRecord.java +++ b/services/core/java/com/android/server/wm/ActivityRecord.java @@ -7343,7 +7343,6 @@ final class ActivityRecord extends WindowToken implements WindowManagerService.A mTransit = TRANSIT_OLD_UNSET; mTransitFlags = 0; mNeedsAnimationBoundsLayer = false; - mDismissKeyguard = false; setAppLayoutChanges(FINISH_LAYOUT_REDO_ANIM | FINISH_LAYOUT_REDO_WALLPAPER, "ActivityRecord"); diff --git a/services/core/java/com/android/server/wm/KeyguardController.java b/services/core/java/com/android/server/wm/KeyguardController.java index cf46126af4888..a4c05eecdb07d 100644 --- a/services/core/java/com/android/server/wm/KeyguardController.java +++ b/services/core/java/com/android/server/wm/KeyguardController.java @@ -595,6 +595,7 @@ class KeyguardController { } else if (top.canShowWhenLocked()) { mTopOccludesActivity = top; } + top.mDismissKeyguard = false; // Only the top activity may control occluded, as we can't occlude the Keyguard // if the top app doesn't want to occlude it.