From e0434555f75a0efc9a396bd4a48ef3fd1cb0094c Mon Sep 17 00:00:00 2001 From: Marin Shalamanov Date: Wed, 3 Feb 2021 12:37:50 +0100 Subject: [PATCH] Extend the comment for setFrameRate(..., shouldBeSeamless) Bug: 179116474 Test: n/a Change-Id: Ief2886313ec3d0334e89ac2bb2bbaf06f74e60a8 --- core/java/android/view/Surface.java | 4 +++- core/java/android/view/SurfaceControl.java | 5 ++++- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/core/java/android/view/Surface.java b/core/java/android/view/Surface.java index 24bc308743181..f8c4d1587f228 100644 --- a/core/java/android/view/Surface.java +++ b/core/java/android/view/Surface.java @@ -928,7 +928,9 @@ public class Surface implements Parcelable { * seamless transition is one that doesn't have any visual interruptions, such as a black * screen for a second or two. True indicates that any frame rate changes caused by this * request should be seamless. False indicates that non-seamless refresh rates are also - * acceptable. + * acceptable. Non-seamless switches might be used when the benefit of matching the content's + * frame rate outweighs the cost of the transition, for example when displaying + * long-running video content. * * @throws IllegalArgumentException If frameRate or compatibility are invalid. */ diff --git a/core/java/android/view/SurfaceControl.java b/core/java/android/view/SurfaceControl.java index acd25077fb5ad..efa33f7cc6a83 100644 --- a/core/java/android/view/SurfaceControl.java +++ b/core/java/android/view/SurfaceControl.java @@ -3252,7 +3252,10 @@ public final class SurfaceControl implements Parcelable { * interruptions, such as a black screen for a second or two. True * indicates that any frame rate changes caused by this request * should be seamless. False indicates that non-seamless refresh - * rates are also acceptable. + * rates are also acceptable. Non-seamless switches might be + * used when the benefit of matching the content's frame rate + * outweighs the cost of the transition, for example when + * displaying long-running video content. * @return This transaction object. */ @NonNull