From dfb57724474d5688e29a11ea16af068218fb1398 Mon Sep 17 00:00:00 2001 From: Alex Klyubin Date: Thu, 31 Mar 2016 12:06:18 -0700 Subject: [PATCH] Remove support for DSA with SHA-512 from v2 sig verification. Android platform does not support DSA with SHA-512. Thus, it does not make sense to support this unsupported algorithm in APK Signature Scheme v2. Bug: 24331392 Change-Id: Ie90b3dd8dd67bad65c64dfb7f6bf427e8ed282ba --- .../java/android/util/apk/ApkSignatureSchemeV2Verifier.java | 6 ------ 1 file changed, 6 deletions(-) diff --git a/core/java/android/util/apk/ApkSignatureSchemeV2Verifier.java b/core/java/android/util/apk/ApkSignatureSchemeV2Verifier.java index d9227cea3b60b..78d3b7bf81d28 100644 --- a/core/java/android/util/apk/ApkSignatureSchemeV2Verifier.java +++ b/core/java/android/util/apk/ApkSignatureSchemeV2Verifier.java @@ -606,7 +606,6 @@ public class ApkSignatureSchemeV2Verifier { private static final int SIGNATURE_ECDSA_WITH_SHA256 = 0x0201; private static final int SIGNATURE_ECDSA_WITH_SHA512 = 0x0202; private static final int SIGNATURE_DSA_WITH_SHA256 = 0x0301; - private static final int SIGNATURE_DSA_WITH_SHA512 = 0x0302; private static final int CONTENT_DIGEST_CHUNKED_SHA256 = 1; private static final int CONTENT_DIGEST_CHUNKED_SHA512 = 2; @@ -620,7 +619,6 @@ public class ApkSignatureSchemeV2Verifier { case SIGNATURE_ECDSA_WITH_SHA256: case SIGNATURE_ECDSA_WITH_SHA512: case SIGNATURE_DSA_WITH_SHA256: - case SIGNATURE_DSA_WITH_SHA512: return true; default: return false; @@ -670,7 +668,6 @@ public class ApkSignatureSchemeV2Verifier { case SIGNATURE_RSA_PSS_WITH_SHA512: case SIGNATURE_RSA_PKCS1_V1_5_WITH_SHA512: case SIGNATURE_ECDSA_WITH_SHA512: - case SIGNATURE_DSA_WITH_SHA512: return CONTENT_DIGEST_CHUNKED_SHA512; default: throw new IllegalArgumentException( @@ -714,7 +711,6 @@ public class ApkSignatureSchemeV2Verifier { case SIGNATURE_ECDSA_WITH_SHA512: return "EC"; case SIGNATURE_DSA_WITH_SHA256: - case SIGNATURE_DSA_WITH_SHA512: return "DSA"; default: throw new IllegalArgumentException( @@ -746,8 +742,6 @@ public class ApkSignatureSchemeV2Verifier { return Pair.create("SHA512withECDSA", null); case SIGNATURE_DSA_WITH_SHA256: return Pair.create("SHA256withDSA", null); - case SIGNATURE_DSA_WITH_SHA512: - return Pair.create("SHA512withDSA", null); default: throw new IllegalArgumentException( "Unknown signature algorithm: 0x"