From dee5a4dc2a5a6829e5509fc0e94903e30dcc238f Mon Sep 17 00:00:00 2001 From: "Tadashi G. Takaoka" Date: Wed, 19 Sep 2018 11:59:40 +0900 Subject: [PATCH] DO NOT MERGE: Move AM/WM unit tests out of FrameworksServicesTests to WmTests Test: All presubmit and non-flaky tests pass 129 com.android.server.am 176 com.android.server.wm 32 com.android.server.policy $ tradefed.sh run commandAndExit WmTests \ --include-filter com.android.server.am. \ --include-annotation android.platform.test.annotations.Presubmit \ --exclude-annotation android.support.test.filters.FlakyTest $ tradefed.sh run commandAndExit WmTests \ --include-filter com.android.server.wm. \ --include-annotation android.platform.test.annotations.Presubmit \ --exclude-annotation android.support.test.filters.FlakyTest $ tradefed.sh run commandAndExit WmTests \ --include-filter com.android.server.policy. \ --include-annotation android.platform.test.annotations.Presubmit \ --exclude-annotation android.support.test.filters.FlakyTest Test: No AM/WM unit test in FrameworksServicesTests $ tradefed.sh run commandAndExit FrameworksServicesTests \ --include-filter com.android.server.am. $ tradefed.sh run commandAndExit FrameworksServicesTests \ --include-filter com.android.server.wm. $ tradefed.sh run commandAndExit FrameworksServicesTests \ --include-filter com.android.server.policy. Bug: 113800711 Change-Id: I01ab256aabf7e1f1b513fe3b92140f6936c2d649 --- services/tests/wmtests/Android.mk | 7 ++- services/tests/wmtests/AndroidManifest.xml | 24 ++++++++- services/tests/wmtests/AndroidTest.xml | 6 +-- .../am/ActivityLaunchParamsModifierTests.java | 26 +++++----- .../am/ActivityManagerInternalTest.java | 13 +---- .../server/am/ActivityManagerServiceTest.java | 16 ++---- .../server/am/ActivityManagerTest.java | 9 +++- .../server/am/ActivityRecordTests.java | 9 +--- .../am/ActivityStackSupervisorTests.java | 2 +- .../android/server/am/ActivityStackTests.java | 8 +-- .../am/ActivityStartControllerTests.java | 18 +++---- .../am/ActivityStartInterceptorTest.java | 2 +- .../server/am/ActivityStarterTests.java | 45 ++++++++-------- .../android/server/am/ActivityTestsBase.java | 19 +++---- .../android/server/am/AppErrorDialogTest.java | 5 +- .../server/am/AssistDataRequesterTest.java | 3 +- .../am/ClientLifecycleManagerTests.java | 22 ++++++++ .../server/am/CoreSettingsObserverTest.java | 14 +---- .../com/android/server/am/DummyAmTests.java | 46 ----------------- .../GlobalSettingsToPropertiesMapperTest.java | 3 ++ .../am/LaunchParamsControllerTests.java | 38 +++++++------- .../server/am/LockTaskControllerTest.java | 19 +++++-- .../android/server/am/MemoryStatUtilTest.java | 8 ++- .../PendingRemoteAnimationRegistryTest.java | 8 +-- .../server/am/PersistentConnectionTest.java | 7 +++ .../android/server/am/RecentTasksTest.java | 10 ++-- .../server/am/RecentsAnimationTest.java | 13 +++-- .../android/server/am/RunningTasksTest.java | 9 ++-- .../server/am/SafeActivityOptionsTest.java | 6 +++ .../am/TaskLaunchParamsModifierTests.java | 30 ++++------- .../android/server/am/TaskPersisterTest.java | 12 ++--- .../android/server/am/TaskRecordTests.java | 8 +-- .../am/TaskStackChangedListenerTest.java | 16 ++++-- .../android/server/am/UserControllerTest.java | 51 ++++++++++--------- .../server/policy/FakeWindowState.java | 0 .../policy/PhoneWindowManagerInsetsTest.java | 0 .../policy/PhoneWindowManagerLayoutTest.java | 0 .../server/policy/PhoneWindowManagerTest.java | 0 .../policy/PhoneWindowManagerTestBase.java | 0 .../AnimatingAppWindowTokenRegistryTest.java | 12 ++--- .../android/server/wm/AppTransitionTests.java | 4 +- .../wm/AppWindowContainerControllerTests.java | 20 ++++---- .../server/wm/AppWindowTokenTests.java | 24 +++++---- .../wm/BoundsAnimationControllerTests.java | 21 +++----- .../wm/ConfigurationContainerTests.java | 5 +- .../com/android/server/wm/DimmerTests.java | 4 +- .../server/wm/DisplayContentTests.java | 9 ++-- .../server/wm/DragDropControllerTests.java | 11 ++-- .../com/android/server/wm/DummyWmTests.java | 46 ----------------- .../server/wm/PinnedStackControllerTest.java | 24 +++++---- .../wm/RecentsAnimationControllerTest.java | 9 +++- .../wm/RemoteAnimationControllerTest.java | 6 ++- .../server/wm/RootWindowContainerTests.java | 9 ++-- .../server/wm/ScreenDecorWindowTests.java | 3 +- .../server/wm/StackWindowControllerTests.java | 19 ++++--- .../server/wm/SurfaceAnimationRunnerTest.java | 10 ++-- .../server/wm/SurfaceAnimatorTest.java | 5 +- .../server/wm/TaskPositionerTests.java | 26 +++++----- .../wm/TaskPositioningControllerTests.java | 5 +- .../server/wm/TaskSnapshotCacheTest.java | 4 +- .../server/wm/TaskSnapshotControllerTest.java | 11 ++-- .../wm/TaskSnapshotPersisterLoaderTest.java | 7 +-- .../wm/TaskSnapshotPersisterTestBase.java | 0 .../server/wm/TaskSnapshotSurfaceTest.java | 4 +- .../server/wm/TaskStackContainersTests.java | 15 +++--- .../com/android/server/wm/TaskStackTests.java | 19 +++---- .../TaskWindowContainerControllerTests.java | 15 +++--- .../com/android/server/wm/TestIWindow.java | 4 +- .../server/wm/TestWindowManagerPolicy.java | 0 .../UnknownAppVisibilityControllerTest.java | 3 +- .../server/wm/WallpaperControllerTests.java | 0 .../server/wm/WindowAnimationSpecTest.java | 3 +- .../server/wm/WindowConfigurationTests.java | 24 ++++----- .../wm/WindowContainerControllerTests.java | 20 ++++---- .../server/wm/WindowContainerTests.java | 31 ++++++----- .../wm/WindowContainerTraversalTests.java | 8 +-- .../android/server/wm/WindowFrameTests.java | 22 ++++---- .../server/wm/WindowManagerServiceRule.java | 0 .../wm/WindowManagerServiceRuleTest.java | 0 .../android/server/wm/WindowStateTests.java | 25 ++++----- .../server/wm/WindowSurfacePlacerTest.java | 7 +++ .../android/server/wm/WindowTestUtils.java | 20 ++++---- .../android/server/wm/WindowTestsBase.java | 0 .../android/server/wm/WindowTokenTests.java | 24 ++++----- .../android/server/wm/WindowTracingTest.java | 5 +- .../com/android/server/wm/ZOrderingTests.java | 5 +- .../wm/utils/CoordinateTransformsTest.java | 13 +++-- .../server/wm/utils/InsetUtilsTest.java | 7 ++- .../server/wm/utils/RotationCacheTest.java | 9 ++-- .../server/wm/utils/WmDisplayCutoutTest.java | 4 +- 90 files changed, 558 insertions(+), 555 deletions(-) rename services/tests/{servicestests => wmtests}/src/com/android/server/am/ActivityLaunchParamsModifierTests.java (97%) rename services/tests/{servicestests => wmtests}/src/com/android/server/am/ActivityManagerInternalTest.java (94%) rename services/tests/{servicestests => wmtests}/src/com/android/server/am/ActivityManagerServiceTest.java (98%) rename services/tests/{servicestests => wmtests}/src/com/android/server/am/ActivityManagerTest.java (94%) rename services/tests/{servicestests => wmtests}/src/com/android/server/am/ActivityRecordTests.java (96%) rename services/tests/{servicestests => wmtests}/src/com/android/server/am/ActivityStackSupervisorTests.java (99%) rename services/tests/{servicestests => wmtests}/src/com/android/server/am/ActivityStackTests.java (99%) rename services/tests/{servicestests => wmtests}/src/com/android/server/am/ActivityStartControllerTests.java (98%) rename services/tests/{servicestests => wmtests}/src/com/android/server/am/ActivityStartInterceptorTest.java (99%) rename services/tests/{servicestests => wmtests}/src/com/android/server/am/ActivityStarterTests.java (98%) rename services/tests/{servicestests => wmtests}/src/com/android/server/am/ActivityTestsBase.java (99%) rename services/tests/{servicestests => wmtests}/src/com/android/server/am/AppErrorDialogTest.java (95%) rename services/tests/{servicestests => wmtests}/src/com/android/server/am/AssistDataRequesterTest.java (99%) rename services/tests/{servicestests => wmtests}/src/com/android/server/am/ClientLifecycleManagerTests.java (66%) rename services/tests/{servicestests => wmtests}/src/com/android/server/am/CoreSettingsObserverTest.java (91%) delete mode 100644 services/tests/wmtests/src/com/android/server/am/DummyAmTests.java rename services/tests/{servicestests => wmtests}/src/com/android/server/am/GlobalSettingsToPropertiesMapperTest.java (98%) rename services/tests/{servicestests => wmtests}/src/com/android/server/am/LaunchParamsControllerTests.java (99%) rename services/tests/{servicestests => wmtests}/src/com/android/server/am/LockTaskControllerTest.java (97%) rename services/tests/{servicestests => wmtests}/src/com/android/server/am/MemoryStatUtilTest.java (97%) rename services/tests/{servicestests => wmtests}/src/com/android/server/am/PendingRemoteAnimationRegistryTest.java (96%) rename services/tests/{servicestests => wmtests}/src/com/android/server/am/PersistentConnectionTest.java (99%) rename services/tests/{servicestests => wmtests}/src/com/android/server/am/RecentTasksTest.java (99%) rename services/tests/{servicestests => wmtests}/src/com/android/server/am/RecentsAnimationTest.java (93%) rename services/tests/{servicestests => wmtests}/src/com/android/server/am/RunningTasksTest.java (97%) rename services/tests/{servicestests => wmtests}/src/com/android/server/am/SafeActivityOptionsTest.java (93%) rename services/tests/{servicestests => wmtests}/src/com/android/server/am/TaskLaunchParamsModifierTests.java (97%) rename services/tests/{servicestests => wmtests}/src/com/android/server/am/TaskPersisterTest.java (93%) rename services/tests/{servicestests => wmtests}/src/com/android/server/am/TaskRecordTests.java (96%) rename services/tests/{servicestests => wmtests}/src/com/android/server/am/TaskStackChangedListenerTest.java (98%) rename services/tests/{servicestests => wmtests}/src/com/android/server/am/UserControllerTest.java (99%) rename services/tests/{servicestests => wmtests}/src/com/android/server/policy/FakeWindowState.java (100%) rename services/tests/{servicestests => wmtests}/src/com/android/server/policy/PhoneWindowManagerInsetsTest.java (100%) rename services/tests/{servicestests => wmtests}/src/com/android/server/policy/PhoneWindowManagerLayoutTest.java (100%) rename services/tests/{servicestests => wmtests}/src/com/android/server/policy/PhoneWindowManagerTest.java (100%) rename services/tests/{servicestests => wmtests}/src/com/android/server/policy/PhoneWindowManagerTestBase.java (100%) rename services/tests/{servicestests => wmtests}/src/com/android/server/wm/AnimatingAppWindowTokenRegistryTest.java (89%) rename services/tests/{servicestests => wmtests}/src/com/android/server/wm/AppTransitionTests.java (98%) rename services/tests/{servicestests => wmtests}/src/com/android/server/wm/AppWindowContainerControllerTests.java (99%) rename services/tests/{servicestests => wmtests}/src/com/android/server/wm/AppWindowTokenTests.java (99%) rename services/tests/{servicestests => wmtests}/src/com/android/server/wm/BoundsAnimationControllerTests.java (98%) rename services/tests/{servicestests => wmtests}/src/com/android/server/wm/ConfigurationContainerTests.java (99%) rename services/tests/{servicestests => wmtests}/src/com/android/server/wm/DimmerTests.java (99%) rename services/tests/{servicestests => wmtests}/src/com/android/server/wm/DisplayContentTests.java (99%) rename services/tests/{servicestests => wmtests}/src/com/android/server/wm/DragDropControllerTests.java (98%) delete mode 100644 services/tests/wmtests/src/com/android/server/wm/DummyWmTests.java rename services/tests/{servicestests => wmtests}/src/com/android/server/wm/PinnedStackControllerTest.java (95%) rename services/tests/{servicestests => wmtests}/src/com/android/server/wm/RecentsAnimationControllerTest.java (97%) rename services/tests/{servicestests => wmtests}/src/com/android/server/wm/RemoteAnimationControllerTest.java (98%) rename services/tests/{servicestests => wmtests}/src/com/android/server/wm/RootWindowContainerTests.java (95%) rename services/tests/{servicestests => wmtests}/src/com/android/server/wm/ScreenDecorWindowTests.java (99%) rename services/tests/{servicestests => wmtests}/src/com/android/server/wm/StackWindowControllerTests.java (98%) rename services/tests/{servicestests => wmtests}/src/com/android/server/wm/SurfaceAnimationRunnerTest.java (97%) rename services/tests/{servicestests => wmtests}/src/com/android/server/wm/SurfaceAnimatorTest.java (99%) rename services/tests/{servicestests => wmtests}/src/com/android/server/wm/TaskPositionerTests.java (99%) rename services/tests/{servicestests => wmtests}/src/com/android/server/wm/TaskPositioningControllerTests.java (98%) rename services/tests/{servicestests => wmtests}/src/com/android/server/wm/TaskSnapshotCacheTest.java (98%) rename services/tests/{servicestests => wmtests}/src/com/android/server/wm/TaskSnapshotControllerTest.java (95%) rename services/tests/{servicestests => wmtests}/src/com/android/server/wm/TaskSnapshotPersisterLoaderTest.java (99%) rename services/tests/{servicestests => wmtests}/src/com/android/server/wm/TaskSnapshotPersisterTestBase.java (100%) rename services/tests/{servicestests => wmtests}/src/com/android/server/wm/TaskSnapshotSurfaceTest.java (99%) rename services/tests/{servicestests => wmtests}/src/com/android/server/wm/TaskStackContainersTests.java (96%) rename services/tests/{servicestests => wmtests}/src/com/android/server/wm/TaskStackTests.java (95%) rename services/tests/{servicestests => wmtests}/src/com/android/server/wm/TaskWindowContainerControllerTests.java (98%) rename services/tests/{servicestests => wmtests}/src/com/android/server/wm/TestIWindow.java (100%) rename services/tests/{servicestests => wmtests}/src/com/android/server/wm/TestWindowManagerPolicy.java (100%) rename services/tests/{servicestests => wmtests}/src/com/android/server/wm/UnknownAppVisibilityControllerTest.java (97%) rename services/tests/{servicestests => wmtests}/src/com/android/server/wm/WallpaperControllerTests.java (100%) rename services/tests/{servicestests => wmtests}/src/com/android/server/wm/WindowAnimationSpecTest.java (98%) rename services/tests/{servicestests => wmtests}/src/com/android/server/wm/WindowConfigurationTests.java (98%) rename services/tests/{servicestests => wmtests}/src/com/android/server/wm/WindowContainerControllerTests.java (97%) rename services/tests/{servicestests => wmtests}/src/com/android/server/wm/WindowContainerTests.java (99%) rename services/tests/{servicestests => wmtests}/src/com/android/server/wm/WindowContainerTraversalTests.java (96%) rename services/tests/{servicestests => wmtests}/src/com/android/server/wm/WindowFrameTests.java (99%) rename services/tests/{servicestests => wmtests}/src/com/android/server/wm/WindowManagerServiceRule.java (100%) rename services/tests/{servicestests => wmtests}/src/com/android/server/wm/WindowManagerServiceRuleTest.java (100%) rename services/tests/{servicestests => wmtests}/src/com/android/server/wm/WindowStateTests.java (99%) rename services/tests/{servicestests => wmtests}/src/com/android/server/wm/WindowSurfacePlacerTest.java (96%) rename services/tests/{servicestests => wmtests}/src/com/android/server/wm/WindowTestUtils.java (99%) rename services/tests/{servicestests => wmtests}/src/com/android/server/wm/WindowTestsBase.java (100%) rename services/tests/{servicestests => wmtests}/src/com/android/server/wm/WindowTokenTests.java (98%) rename services/tests/{servicestests => wmtests}/src/com/android/server/wm/WindowTracingTest.java (98%) rename services/tests/{servicestests => wmtests}/src/com/android/server/wm/ZOrderingTests.java (99%) rename services/tests/{servicestests => wmtests}/src/com/android/server/wm/utils/CoordinateTransformsTest.java (91%) rename services/tests/{servicestests => wmtests}/src/com/android/server/wm/utils/InsetUtilsTest.java (92%) rename services/tests/{servicestests => wmtests}/src/com/android/server/wm/utils/RotationCacheTest.java (97%) rename services/tests/{servicestests => wmtests}/src/com/android/server/wm/utils/WmDisplayCutoutTest.java (98%) diff --git a/services/tests/wmtests/Android.mk b/services/tests/wmtests/Android.mk index 0f8b18ab92cf2..cd289740ea1e3 100644 --- a/services/tests/wmtests/Android.mk +++ b/services/tests/wmtests/Android.mk @@ -14,9 +14,14 @@ LOCAL_SRC_FILES := \ $(call all-java-files-under, ../servicestests/utils) LOCAL_STATIC_JAVA_LIBRARIES := \ - androidx-test \ + frameworks-base-testutils \ + services.core \ + android-support-test \ mockito-target-minus-junit4 \ platform-test-annotations \ + truth-prebuilt \ + testables \ + ub-uiautomator \ LOCAL_JAVA_LIBRARIES := \ android.test.mock \ diff --git a/services/tests/wmtests/AndroidManifest.xml b/services/tests/wmtests/AndroidManifest.xml index 1fb9473090284..7e4bd42c8c550 100644 --- a/services/tests/wmtests/AndroidManifest.xml +++ b/services/tests/wmtests/AndroidManifest.xml @@ -22,10 +22,30 @@ android:minSdkVersion="1" android:targetSdkVersion="28" /> - + + + + + + + + + + + + + + + + + + + + + diff --git a/services/tests/wmtests/AndroidTest.xml b/services/tests/wmtests/AndroidTest.xml index 2717ef901216d..38a62ae9bbe35 100644 --- a/services/tests/wmtests/AndroidTest.xml +++ b/services/tests/wmtests/AndroidTest.xml @@ -24,9 +24,9 @@