From deb0ff2bf4b7a3ffc7440fffc22772dbeca991ea Mon Sep 17 00:00:00 2001 From: Adrian Roos Date: Wed, 27 Feb 2019 23:58:13 +0100 Subject: [PATCH] Apilint: Enforce final builders Test: run apilint Bug: 124883027 Change-Id: I7f2866e46bc40be60487846b2af9f8fd7edb7623 --- tools/apilint/apilint.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/apilint/apilint.py b/tools/apilint/apilint.py index 4c02d94542d0d..ef405e4b1343c 100644 --- a/tools/apilint/apilint.py +++ b/tools/apilint/apilint.py @@ -1109,6 +1109,9 @@ def verify_builder(clazz): if not has_build: warn(clazz, None, None, "Missing build() method") + if "final" not in clazz.split: + error(clazz, None, None, "Builder should be final") + def verify_aidl(clazz): """Catch people exposing raw AIDL."""