From 01243ac57e7be3c409c1238eff352c0e8acbe9ef Mon Sep 17 00:00:00 2001 From: Clara Bayarri Date: Wed, 3 Jun 2015 00:46:29 +0100 Subject: [PATCH] Fix Toolbar is not refreshed after Select All Bug: 21361248 Change-Id: Iab913bd610c208e5881d3d0eb5574efdf9eb5d92 --- core/java/android/widget/Editor.java | 10 +++++++++- core/java/android/widget/TextView.java | 11 +++++++++-- 2 files changed, 18 insertions(+), 3 deletions(-) diff --git a/core/java/android/widget/Editor.java b/core/java/android/widget/Editor.java index 4c98abf7c5297..0c4b1e17f3df6 100644 --- a/core/java/android/widget/Editor.java +++ b/core/java/android/widget/Editor.java @@ -1756,6 +1756,12 @@ public class Editor { if (!checkFieldAndSelectCurrentWord()) { return false; } + + // Avoid dismissing the selection if it exists. + mPreserveDetachedSelection = true; + stopTextActionMode(); + mPreserveDetachedSelection = false; + getSelectionController().enterDrag(); return true; } @@ -3129,7 +3135,9 @@ public class Editor { Callback customCallback = getCustomCallback(); if (customCallback != null) { if (!customCallback.onCreateActionMode(mode, menu)) { - // The custom mode can choose to cancel the action mode + // The custom mode can choose to cancel the action mode, dismiss selection. + Selection.setSelection((Spannable) mTextView.getText(), + mTextView.getSelectionEnd()); return false; } } diff --git a/core/java/android/widget/TextView.java b/core/java/android/widget/TextView.java index 6872caa7189c9..b0411c967233a 100644 --- a/core/java/android/widget/TextView.java +++ b/core/java/android/widget/TextView.java @@ -9072,9 +9072,16 @@ public class TextView extends View implements ViewTreeObserver.OnPreDrawListener switch (id) { case ID_SELECT_ALL: - // This does not enter text selection mode. Text is highlighted, so that it can be - // bulk edited, like selectAllOnFocus does. Returns true even if text is empty. + // This starts an action mode if triggered from another action mode. Text is + // highlighted, so that it can be bulk edited, like selectAllOnFocus does. Returns + // true even if text is empty. + boolean shouldRestartActionMode = + mEditor != null && mEditor.mTextActionMode != null; + stopTextActionMode(); selectAllText(); + if (shouldRestartActionMode) { + mEditor.startSelectionActionMode(); + } return true; case ID_UNDO: