From de5aa37a17df7d1068f0877bf26c69ad5ddaa2e4 Mon Sep 17 00:00:00 2001 From: Ming-Shin Lu Date: Wed, 13 Jul 2022 10:45:36 +0800 Subject: [PATCH] Remove TODO item in IMMS#canShowInputMethodPickerLocked As CL[1] has already supported to show IME picker on the external/Virtual display with the self reported displayId of the current focused client, so currently canShowInputMethodPickerLocked for Single-Session IME usage with switching focus displays should be enough to check if the given client is the focused client. Remove the TODO item to prevent the misleading of not support multi-display for IME picker. [1]: Ic7d7c5a7ad8005a3fbd9d1c1b73e3c5a39a07001 Bug: 238972096 Test: atest InputMethodPickerTest Change-Id: I2bdf3c2a8325d95025196782b9fdaae7441124b7 --- .../android/server/inputmethod/InputMethodManagerService.java | 1 - 1 file changed, 1 deletion(-) diff --git a/services/core/java/com/android/server/inputmethod/InputMethodManagerService.java b/services/core/java/com/android/server/inputmethod/InputMethodManagerService.java index 508f752f0e728..33c484cd53ad1 100644 --- a/services/core/java/com/android/server/inputmethod/InputMethodManagerService.java +++ b/services/core/java/com/android/server/inputmethod/InputMethodManagerService.java @@ -3960,7 +3960,6 @@ public final class InputMethodManagerService extends IInputMethodManager.Stub @GuardedBy("ImfLock.class") private boolean canShowInputMethodPickerLocked(IInputMethodClient client) { - // TODO(yukawa): multi-display support. final int uid = Binder.getCallingUid(); if (mCurFocusedWindowClient != null && client != null && mCurFocusedWindowClient.client.asBinder() == client.asBinder()) {