From de5748e47d5202927cfcec4c3437a2829e5e7524 Mon Sep 17 00:00:00 2001 From: Yohei Yukawa Date: Thu, 27 Dec 2018 08:40:16 -0800 Subject: [PATCH] Clean up IMMS#handleShellCommandResetInputMethod() a bit There should be no observable behavior change. Bug: 34886274 Test: 'adb shell ime reset' still works Change-Id: I45e2b2521b6ac2890f604745f1f2977a5a162610 --- .../InputMethodManagerService.java | 20 ++++--------------- 1 file changed, 4 insertions(+), 16 deletions(-) diff --git a/services/core/java/com/android/server/inputmethod/InputMethodManagerService.java b/services/core/java/com/android/server/inputmethod/InputMethodManagerService.java index 292aae81b421f..c87e5cc081571 100644 --- a/services/core/java/com/android/server/inputmethod/InputMethodManagerService.java +++ b/services/core/java/com/android/server/inputmethod/InputMethodManagerService.java @@ -4841,23 +4841,11 @@ public class InputMethodManagerService extends IInputMethodManager.Stub // Also reset the settings of the current IME mSettings.putSelectedInputMethod(null); // Disable all enabled IMEs. - { - final ArrayList enabledImes = - mSettings.getEnabledInputMethodListLocked(); - final int N = enabledImes.size(); - for (int i = 0; i < N; ++i) { - setInputMethodEnabledLocked(enabledImes.get(i).getId(), false); - } - } + mSettings.getEnabledInputMethodListLocked().forEach( + imi -> setInputMethodEnabledLocked(imi.getId(), false)); // Re-enable with default enabled IMEs. - { - final ArrayList defaultEnabledIme = - InputMethodUtils.getDefaultEnabledImes(mContext, mMethodList); - final int N = defaultEnabledIme.size(); - for (int i = 0; i < N; ++i) { - setInputMethodEnabledLocked(defaultEnabledIme.get(i).getId(), true); - } - } + InputMethodUtils.getDefaultEnabledImes(mContext, mMethodList).forEach( + imi -> setInputMethodEnabledLocked(imi.getId(), true)); updateInputMethodsFromSettingsLocked(true /* enabledMayChange */); InputMethodUtils.setNonSelectedSystemImesDisabledUntilUsed(mIPackageManager, mSettings.getEnabledInputMethodListLocked(),