From de3112e0989295c5aa783b43d83cb1c75f4fb28e Mon Sep 17 00:00:00 2001 From: Austin Borger Date: Thu, 30 Mar 2023 18:37:19 -0700 Subject: [PATCH] AudioService: Use the default UidObserver implementation. A class which overrides IUidObserver.Stub with empty callback implementations was added in change I2ff1e868586861e4dcd6586ad22139ba84eaf39c to simplify BroadcastQueue interface complexity. Using this default implementation will mean less churn when new callbacks are added to IUidObserver, or existing callback method signatures are changed. Bug: 274486653 Test: Presubmit, smoke test on cuttlefish. Change-Id: Ia39312bef7b5b7bddcf76ae2feb3562b7cfbb921 --- .../com/android/server/audio/AudioService.java | 16 ++-------------- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/services/core/java/com/android/server/audio/AudioService.java b/services/core/java/com/android/server/audio/AudioService.java index d43687be61286..53e7ba6545dff 100644 --- a/services/core/java/com/android/server/audio/AudioService.java +++ b/services/core/java/com/android/server/audio/AudioService.java @@ -51,6 +51,7 @@ import android.app.AppOpsManager; import android.app.BroadcastOptions; import android.app.IUidObserver; import android.app.NotificationManager; +import android.app.UidObserver; import android.app.role.OnRoleHoldersChangedListener; import android.app.role.RoleManager; import android.bluetooth.BluetoothAdapter; @@ -959,29 +960,16 @@ public class AudioService extends IAudioService.Stub } } - final private IUidObserver mUidObserver = new IUidObserver.Stub() { - @Override public void onUidStateChanged(int uid, int procState, long procStateSeq, - int capability) { - } - + final private IUidObserver mUidObserver = new UidObserver() { @Override public void onUidGone(int uid, boolean disabled) { // Once the uid is no longer running, no need to keep trying to disable its audio. disableAudioForUid(false, uid); } - @Override public void onUidActive(int uid) throws RemoteException { - } - - @Override public void onUidIdle(int uid, boolean disabled) { - } - @Override public void onUidCachedChanged(int uid, boolean cached) { disableAudioForUid(cached, uid); } - @Override public void onUidProcAdjChanged(int uid) { - } - private void disableAudioForUid(boolean disable, int uid) { queueMsgUnderWakeLock(mAudioHandler, MSG_DISABLE_AUDIO_FOR_UID, disable ? 1 : 0 /* arg1 */, uid /* arg2 */,