From 5d937fc95f2f40c6f920d73fb56f6aef03804441 Mon Sep 17 00:00:00 2001 From: Salvador Martinez Date: Fri, 23 Sep 2016 08:54:20 -0700 Subject: [PATCH] Updated summary logic for wifi Wifi summary claimed it would not reconnect under conditions where it should. This has been changed to properly say when an AP will automatically be reconnected to. Test: make RunSettingsLibRoboTests Bug: 29973023 Change-Id: I2ffb4ec3b83e93c3df9ee179fc6a6bf59acec42e --- packages/SettingsLib/res/values/strings.xml | 4 +++- .../src/com/android/settingslib/wifi/AccessPoint.java | 5 ++++- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/packages/SettingsLib/res/values/strings.xml b/packages/SettingsLib/res/values/strings.xml index 682af8bd536f5..08e5164fb2526 100644 --- a/packages/SettingsLib/res/values/strings.xml +++ b/packages/SettingsLib/res/values/strings.xml @@ -64,8 +64,10 @@ Authentication problem Not in range + + No Internet Access Detected, won\'t automatically reconnect. - No Internet Access Detected, won\'t automatically reconnect. + No Internet Access. Saved by %1$s diff --git a/packages/SettingsLib/src/com/android/settingslib/wifi/AccessPoint.java b/packages/SettingsLib/src/com/android/settingslib/wifi/AccessPoint.java index 92f1b18c94446..b63752c225211 100644 --- a/packages/SettingsLib/src/com/android/settingslib/wifi/AccessPoint.java +++ b/packages/SettingsLib/src/com/android/settingslib/wifi/AccessPoint.java @@ -409,7 +409,10 @@ public class AccessPoint implements Comparable { String format = mContext.getString(R.string.available_via_passpoint); summary.append(String.format(format, config.providerFriendlyName)); } else if (config != null && config.hasNoInternetAccess()) { - summary.append(mContext.getString(R.string.wifi_no_internet)); + int messageID = config.getNetworkSelectionStatus().isNetworkPermanentlyDisabled() + ? R.string.wifi_no_internet_no_reconnect + : R.string.wifi_no_internet; + summary.append(mContext.getString(messageID)); } else if (config != null && !config.getNetworkSelectionStatus().isNetworkEnabled()) { WifiConfiguration.NetworkSelectionStatus networkStatus = config.getNetworkSelectionStatus();