From 845eef05ffea53f4ce7a1e0551896be874c4f302 Mon Sep 17 00:00:00 2001 From: Mathias Agopian Date: Mon, 3 Apr 2017 17:51:15 -0700 Subject: [PATCH] Remove useless GraphicBuffer() constructor Test: compiled & run Bug: 36869708 Change-Id: Ie825979cd03874904b6f953ece4a05d4a0d52253 --- core/jni/android_hardware_camera2_legacy_LegacyCameraDevice.cpp | 2 +- media/jni/android_media_ImageWriter.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/core/jni/android_hardware_camera2_legacy_LegacyCameraDevice.cpp b/core/jni/android_hardware_camera2_legacy_LegacyCameraDevice.cpp index 80f9d5750d8aa..71211948dac34 100644 --- a/core/jni/android_hardware_camera2_legacy_LegacyCameraDevice.cpp +++ b/core/jni/android_hardware_camera2_legacy_LegacyCameraDevice.cpp @@ -182,7 +182,7 @@ static status_t produceFrame(const sp& anw, err = native_window_dequeue_buffer_and_wait(anw.get(), &anb); if (err != NO_ERROR) return err; - sp buf(new GraphicBuffer(anb, /*keepOwnership*/false)); + sp buf(GraphicBuffer::from(anb)); uint32_t grallocBufWidth = buf->getWidth(); uint32_t grallocBufHeight = buf->getHeight(); uint32_t grallocBufStride = buf->getStride(); diff --git a/media/jni/android_media_ImageWriter.cpp b/media/jni/android_media_ImageWriter.cpp index d5d9fc94bf290..0149d76236605 100644 --- a/media/jni/android_media_ImageWriter.cpp +++ b/media/jni/android_media_ImageWriter.cpp @@ -342,7 +342,7 @@ static void ImageWriter_dequeueImage(JNIEnv* env, jobject thiz, jlong nativeCtx, } // New GraphicBuffer object doesn't own the handle, thus the native buffer // won't be freed when this object is destroyed. - sp buffer(new GraphicBuffer(anb, /*keepOwnership*/false)); + sp buffer(GraphicBuffer::from(anb)); // Note that: // 1. No need to lock buffer now, will only lock it when the first getPlanes() is called.