From dc88b241d3df126f3294227aeddd084bf8f547bb Mon Sep 17 00:00:00 2001 From: Nikolas Havrikov Date: Thu, 10 Feb 2022 15:09:45 +0100 Subject: [PATCH] Recycle obtained Parcel Bug: 218835043 Test: make Change-Id: If620ca6cc60c6509088cc4e25f6d7661aac3ab5f --- .../java/com/android/server/content/SyncStorageEngine.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/services/core/java/com/android/server/content/SyncStorageEngine.java b/services/core/java/com/android/server/content/SyncStorageEngine.java index 1894c0fc6045f..2c6257f7cba66 100644 --- a/services/core/java/com/android/server/content/SyncStorageEngine.java +++ b/services/core/java/com/android/server/content/SyncStorageEngine.java @@ -2421,10 +2421,10 @@ public class SyncStorageEngine { public static final int STATISTICS_FILE_ITEM = 101; private void readStatsParcelLocked(File parcel) { + Parcel in = Parcel.obtain(); try { final AtomicFile parcelFile = new AtomicFile(parcel); byte[] data = parcelFile.readFully(); - Parcel in = Parcel.obtain(); in.unmarshall(data, 0, data.length); in.setDataPosition(0); int token; @@ -2452,6 +2452,8 @@ public class SyncStorageEngine { } } catch (IOException e) { Slog.i(TAG, "No initial statistics"); + } finally { + in.recycle(); } }