From dc4679a818d7aab7b82148c1547d7f5aa05ab67f Mon Sep 17 00:00:00 2001 From: Yohei Yukawa Date: Tue, 8 Mar 2022 20:23:17 -0800 Subject: [PATCH] Fix modifier-related lint erros under a.i.navigationbar This is a mechanical cleanup CL. There should be no behavior change. Bug: 215443343 Test: prebuilts/checkstyle/checkstyle.py -f \ frameworks/base/core/java/android/inputmethodservice/navigationbar/ \ | grep "modifier" Change-Id: Idf3c8d13c63770397e895bc05ba2374c10fb3bd1 --- .../inputmethodservice/navigationbar/ButtonDispatcher.java | 2 +- .../android/inputmethodservice/navigationbar/DeadZone.java | 2 +- .../inputmethodservice/navigationbar/KeyButtonDrawable.java | 6 +++--- .../inputmethodservice/navigationbar/KeyButtonRipple.java | 2 +- .../inputmethodservice/navigationbar/NavigationBarView.java | 4 ++-- .../navigationbar/ReverseLinearLayout.java | 4 ++-- 6 files changed, 10 insertions(+), 10 deletions(-) diff --git a/core/java/android/inputmethodservice/navigationbar/ButtonDispatcher.java b/core/java/android/inputmethodservice/navigationbar/ButtonDispatcher.java index 3f26fa461097a..ab0d0a55e7d13 100644 --- a/core/java/android/inputmethodservice/navigationbar/ButtonDispatcher.java +++ b/core/java/android/inputmethodservice/navigationbar/ButtonDispatcher.java @@ -67,7 +67,7 @@ final class ButtonDispatcher { } }; - public ButtonDispatcher(int id) { + ButtonDispatcher(int id) { mId = id; } diff --git a/core/java/android/inputmethodservice/navigationbar/DeadZone.java b/core/java/android/inputmethodservice/navigationbar/DeadZone.java index 4adc84bf0b6fa..15715c0fdb095 100644 --- a/core/java/android/inputmethodservice/navigationbar/DeadZone.java +++ b/core/java/android/inputmethodservice/navigationbar/DeadZone.java @@ -82,7 +82,7 @@ final class DeadZone { } }; - public DeadZone(NavigationBarView view) { + DeadZone(NavigationBarView view) { mNavigationBarView = view; onConfigurationChanged(Surface.ROTATION_0); } diff --git a/core/java/android/inputmethodservice/navigationbar/KeyButtonDrawable.java b/core/java/android/inputmethodservice/navigationbar/KeyButtonDrawable.java index 25a443de916bc..cd645843550df 100644 --- a/core/java/android/inputmethodservice/navigationbar/KeyButtonDrawable.java +++ b/core/java/android/inputmethodservice/navigationbar/KeyButtonDrawable.java @@ -100,7 +100,7 @@ final class KeyButtonDrawable extends Drawable { } }; - public KeyButtonDrawable(Drawable d, @ColorInt int lightColor, @ColorInt int darkColor, + KeyButtonDrawable(Drawable d, @ColorInt int lightColor, @ColorInt int darkColor, boolean horizontalFlip, Color ovalBackgroundColor) { this(d, new ShadowDrawableState(lightColor, darkColor, d instanceof AnimatedVectorDrawable, horizontalFlip, ovalBackgroundColor)); @@ -433,8 +433,8 @@ final class KeyButtonDrawable extends Drawable { final boolean mSupportsAnimation; final Color mOvalBackgroundColor; - public ShadowDrawableState(@ColorInt int lightColor, @ColorInt int darkColor, - boolean animated, boolean horizontalFlip, Color ovalBackgroundColor) { + ShadowDrawableState(@ColorInt int lightColor, @ColorInt int darkColor, boolean animated, + boolean horizontalFlip, Color ovalBackgroundColor) { mLightColor = lightColor; mDarkColor = darkColor; mSupportsAnimation = animated; diff --git a/core/java/android/inputmethodservice/navigationbar/KeyButtonRipple.java b/core/java/android/inputmethodservice/navigationbar/KeyButtonRipple.java index 38a63b661ac07..7d1d4fbf16de9 100644 --- a/core/java/android/inputmethodservice/navigationbar/KeyButtonRipple.java +++ b/core/java/android/inputmethodservice/navigationbar/KeyButtonRipple.java @@ -90,7 +90,7 @@ final class KeyButtonRipple extends Drawable { private Type mType = Type.ROUNDED_RECT; - public KeyButtonRipple(Context ctx, View targetView, @DimenRes int maxWidthResource) { + KeyButtonRipple(Context ctx, View targetView, @DimenRes int maxWidthResource) { mMaxWidthResource = maxWidthResource; mMaxWidth = ctx.getResources().getDimensionPixelSize(maxWidthResource); mTargetView = targetView; diff --git a/core/java/android/inputmethodservice/navigationbar/NavigationBarView.java b/core/java/android/inputmethodservice/navigationbar/NavigationBarView.java index 875f53fdd94ea..67129eed20864 100644 --- a/core/java/android/inputmethodservice/navigationbar/NavigationBarView.java +++ b/core/java/android/inputmethodservice/navigationbar/NavigationBarView.java @@ -48,8 +48,8 @@ import java.util.function.Consumer; * @hide */ public final class NavigationBarView extends FrameLayout { - final static boolean DEBUG = false; - final static String TAG = "NavBarView"; + private static final boolean DEBUG = false; + private static final String TAG = "NavBarView"; // Copied from com.android.systemui.animation.Interpolators#FAST_OUT_SLOW_IN private static final Interpolator FAST_OUT_SLOW_IN = new PathInterpolator(0.4f, 0f, 0.2f, 1f); diff --git a/core/java/android/inputmethodservice/navigationbar/ReverseLinearLayout.java b/core/java/android/inputmethodservice/navigationbar/ReverseLinearLayout.java index 72e720f535eb7..9b36cc54b6571 100644 --- a/core/java/android/inputmethodservice/navigationbar/ReverseLinearLayout.java +++ b/core/java/android/inputmethodservice/navigationbar/ReverseLinearLayout.java @@ -39,7 +39,7 @@ class ReverseLinearLayout extends LinearLayout { /** If true, the layout is opposite to it's natural reversity from the layout direction */ private boolean mIsAlternativeOrder; - public ReverseLinearLayout(Context context, @Nullable AttributeSet attrs) { + ReverseLinearLayout(Context context, @Nullable AttributeSet attrs) { super(context, attrs); } @@ -128,7 +128,7 @@ class ReverseLinearLayout extends LinearLayout { public static class ReverseRelativeLayout extends RelativeLayout implements Reversible { - public ReverseRelativeLayout(Context context) { + ReverseRelativeLayout(Context context) { super(context); }