From b199568a4a9eaccd5db7dcd651dc0ce580312156 Mon Sep 17 00:00:00 2001 From: Leon Scroggins III Date: Fri, 5 Apr 2019 13:15:08 -0400 Subject: [PATCH] Remove redundant calls to invalidateParentIfNeeded Test: CtsViewTestCases setLeft, setTop, setRight, and setBottom called it once, and then potentially called it again. The second call is unnecessary. Change-Id: If92d4b786d4680024614042cd8905ae56ea1c9e9 --- core/java/android/view/View.java | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/core/java/android/view/View.java b/core/java/android/view/View.java index 65fe87fa8ca01..8cf6652ba723d 100644 --- a/core/java/android/view/View.java +++ b/core/java/android/view/View.java @@ -16815,10 +16815,6 @@ public class View implements Drawable.Callback, KeyEvent.Callback, mForegroundInfo.mBoundsChanged = true; } invalidateParentIfNeeded(); - if ((mPrivateFlags2 & PFLAG2_VIEW_QUICK_REJECTED) == PFLAG2_VIEW_QUICK_REJECTED) { - // View was rejected last time it was drawn by its parent; this may have changed - invalidateParentIfNeeded(); - } } } @@ -16884,10 +16880,6 @@ public class View implements Drawable.Callback, KeyEvent.Callback, mForegroundInfo.mBoundsChanged = true; } invalidateParentIfNeeded(); - if ((mPrivateFlags2 & PFLAG2_VIEW_QUICK_REJECTED) == PFLAG2_VIEW_QUICK_REJECTED) { - // View was rejected last time it was drawn by its parent; this may have changed - invalidateParentIfNeeded(); - } } } @@ -16947,10 +16939,6 @@ public class View implements Drawable.Callback, KeyEvent.Callback, mForegroundInfo.mBoundsChanged = true; } invalidateParentIfNeeded(); - if ((mPrivateFlags2 & PFLAG2_VIEW_QUICK_REJECTED) == PFLAG2_VIEW_QUICK_REJECTED) { - // View was rejected last time it was drawn by its parent; this may have changed - invalidateParentIfNeeded(); - } } } @@ -17007,10 +16995,6 @@ public class View implements Drawable.Callback, KeyEvent.Callback, mForegroundInfo.mBoundsChanged = true; } invalidateParentIfNeeded(); - if ((mPrivateFlags2 & PFLAG2_VIEW_QUICK_REJECTED) == PFLAG2_VIEW_QUICK_REJECTED) { - // View was rejected last time it was drawn by its parent; this may have changed - invalidateParentIfNeeded(); - } } }