From efcac2ffba6262829093c4388c35f93b0ba0510e Mon Sep 17 00:00:00 2001 From: Srilakshmi Punuru Date: Mon, 9 Aug 2010 23:48:12 -0700 Subject: [PATCH] InputMethodManagerService: Fix acore crash on boot up At bootup, while starting the service, if the default Input Method is not set, it is trying to disable the icon even before the statusbar variable and the input method icon are initialized. Hence, initializing them before building the input method list. Change-Id: Ibde2ca3bd379d6620d84b75662ffad1a95a24fc6 --- .../com/android/server/InputMethodManagerService.java | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/services/java/com/android/server/InputMethodManagerService.java b/services/java/com/android/server/InputMethodManagerService.java index 0e741690b78a0..5a995aed847a9 100644 --- a/services/java/com/android/server/InputMethodManagerService.java +++ b/services/java/com/android/server/InputMethodManagerService.java @@ -469,6 +469,11 @@ public class InputMethodManagerService extends IInputMethodManager.Stub screenOnOffFilt.addAction(Intent.ACTION_CLOSE_SYSTEM_DIALOGS); mContext.registerReceiver(new ScreenOnOffReceiver(), screenOnOffFilt); + mStatusBar = statusBar; + mInputMethodData = IconData.makeIcon("ime", null, 0, 0, 0); + mInputMethodIcon = statusBar.addIcon(mInputMethodData, null); + statusBar.setIconVisibility(mInputMethodIcon, false); + buildInputMethodListLocked(mMethodList, mMethodMap); final String enabledStr = Settings.Secure.getString( @@ -510,11 +515,6 @@ public class InputMethodManagerService extends IInputMethodManager.Stub } } - mStatusBar = statusBar; - mInputMethodData = IconData.makeIcon("ime", null, 0, 0, 0); - mInputMethodIcon = statusBar.addIcon(mInputMethodData, null); - statusBar.setIconVisibility(mInputMethodIcon, false); - mSettingsObserver = new SettingsObserver(mHandler); updateFromSettingsLocked(); }