From dbcb2c68ee64f3c949079f126b8531c067fafbf7 Mon Sep 17 00:00:00 2001 From: Andreas Huber Date: Thu, 14 Jan 2010 11:32:13 -0800 Subject: [PATCH] Workaround for some hardware decoders not properly signaling end-of-output-stream properly. --- media/libstagefright/OMXCodec.cpp | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/media/libstagefright/OMXCodec.cpp b/media/libstagefright/OMXCodec.cpp index d8bd25d28766b..c4d3b5dfa03ae 100644 --- a/media/libstagefright/OMXCodec.cpp +++ b/media/libstagefright/OMXCodec.cpp @@ -1786,6 +1786,21 @@ void OMXCodec::enablePortAsync(OMX_U32 portIndex) { void OMXCodec::fillOutputBuffers() { CHECK_EQ(mState, EXECUTING); + // This is a workaround for some decoders not properly reporting + // end-of-output-stream. If we own all input buffers and also own + // all output buffers and we already signalled end-of-input-stream, + // the end-of-output-stream is implied. + if (mSignalledEOS + && countBuffersWeOwn(mPortBuffers[kPortIndexInput]) + == mPortBuffers[kPortIndexInput].size() + && countBuffersWeOwn(mPortBuffers[kPortIndexOutput]) + == mPortBuffers[kPortIndexOutput].size()) { + mNoMoreOutputData = true; + mBufferFilled.signal(); + + return; + } + Vector *buffers = &mPortBuffers[kPortIndexOutput]; for (size_t i = 0; i < buffers->size(); ++i) { fillOutputBuffer(&buffers->editItemAt(i)); @@ -1833,6 +1848,8 @@ void OMXCodec::drainInputBuffer(BufferInfo *info) { mNoMoreOutputData = false; + CODEC_LOGV("calling emptyBuffer with codec specific data"); + status_t err = mOMX->emptyBuffer( mNode, info->mBuffer, 0, size, OMX_BUFFERFLAG_ENDOFFRAME | OMX_BUFFERFLAG_CODECCONFIG,