From 8860d574aff0f4dda7f7862489cf4603ada9f126 Mon Sep 17 00:00:00 2001
From: Roy Chou <juchengchou@google.com>
Date: Thu, 4 May 2023 07:45:53 +0000
Subject: [PATCH] fix(non linear font scaling)!: fix status bar date/battery
 text being cut off when 200% font scaling

We adjust related height dimens to assure the date and battery percentage textview could display properly when large font scaling. Besides, the BatteryStatusChip height should also update when font scaling changed to ensure the battery percentage text would not be cut off. Therefore, we also adjust the dimen from dp to sp.

For this CL, we only adjust the height dimens to fix the text cut off issue. The icon scaling issue would be in future CLs.

Bug: 272071029
Test: manually - screenshot attached in bug
Change-Id: Idbc27deff035d34706b534bd5cb3a8dbb36fc9d0
---
 packages/SystemUI/res/values/dimens.xml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/packages/SystemUI/res/values/dimens.xml b/packages/SystemUI/res/values/dimens.xml
index aff0e8052739a..3f37f41dbfdee 100644
--- a/packages/SystemUI/res/values/dimens.xml
+++ b/packages/SystemUI/res/values/dimens.xml
@@ -618,8 +618,8 @@
     <dimen name="qs_header_height">120dp</dimen>
     <dimen name="qs_header_row_min_height">48dp</dimen>
 
-    <dimen name="qs_header_non_clickable_element_height">24dp</dimen>
-    <dimen name="new_qs_header_non_clickable_element_height">24dp</dimen>
+    <dimen name="qs_header_non_clickable_element_height">24sp</dimen>
+    <dimen name="new_qs_header_non_clickable_element_height">24sp</dimen>
 
     <dimen name="qs_footer_padding">20dp</dimen>
     <dimen name="qs_security_footer_height">88dp</dimen>
@@ -1043,7 +1043,7 @@
     <dimen name="display_cutout_margin_consumption">0px</dimen>
 
     <!-- Height of the Ongoing App Ops chip -->
-    <dimen name="ongoing_appops_chip_height">24dp</dimen>
+    <dimen name="ongoing_appops_chip_height">24sp</dimen>
     <!-- Side padding between background of Ongoing App Ops chip and content -->
     <dimen name="ongoing_appops_chip_side_padding">8dp</dimen>
     <!-- Margin between icons of Ongoing App Ops chip -->