From db0dbea1908930c5ec3bddd5d2889ddfef7e818b Mon Sep 17 00:00:00 2001 From: "Qi (wangqi) Wang" Date: Wed, 24 Jun 2020 19:42:20 -0700 Subject: [PATCH] Fix the visibility of SurfaceView in InlineContentView. SurfaceView doesn't respect the visibility of its ancestor so we need to update it accordingly inside InlineContentView. Test: manually Bug: 158714351 Change-Id: If482747d6ae5d7628b46de837c11b6232406120c --- core/java/android/widget/inline/InlineContentView.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/core/java/android/widget/inline/InlineContentView.java b/core/java/android/widget/inline/InlineContentView.java index 1b666aa67e905..9712311aab7c4 100644 --- a/core/java/android/widget/inline/InlineContentView.java +++ b/core/java/android/widget/inline/InlineContentView.java @@ -21,8 +21,8 @@ import android.annotation.Nullable; import android.annotation.TestApi; import android.content.Context; import android.graphics.PixelFormat; -import android.graphics.Rect; import android.graphics.PointF; +import android.graphics.Rect; import android.util.AttributeSet; import android.util.Log; import android.view.SurfaceControl; @@ -156,7 +156,8 @@ public class InlineContentView extends ViewGroup { @Override public void onDraw() { computeParentPositionAndScale(); - mSurfaceView.setVisibility(VISIBLE); + final int visibility = InlineContentView.this.isShown() ? VISIBLE : GONE; + mSurfaceView.setVisibility(visibility); } };