From 977d943494d4f1bfbc99fa766b33ab67211dba3c Mon Sep 17 00:00:00 2001 From: Selim Gurun Date: Tue, 16 Feb 2016 12:30:08 -0800 Subject: [PATCH] Better document the ignore behavior for client cert api Bug: 26361557 When the embedded app requests a ignore of a client cert request, webview does not cache the response of the app. However, underlying layers could. Clarify the document. Change-Id: I43e6a4c91727f71c88ca69e1334f64de9f66905a --- core/java/android/webkit/WebViewClient.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/core/java/android/webkit/WebViewClient.java b/core/java/android/webkit/WebViewClient.java index 0e5034de7f4f2..8318656342d76 100644 --- a/core/java/android/webkit/WebViewClient.java +++ b/core/java/android/webkit/WebViewClient.java @@ -332,7 +332,9 @@ public class WebViewClient { * in memory (for the life of the application) if proceed() or cancel() is * called and does not call onReceivedClientCertRequest() again for the * same host and port pair. Webview does not store the response if ignore() - * is called. + * is called. Note that, multiple layers in chromium network stack might be + * caching the responses, so the behavior for ignore is only a best case + * effort. * * This method is called on the UI thread. During the callback, the * connection is suspended.