Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Ignore exceptions when investigating failure reasons" into rvc-dev

Browse Source
This commit is contained in:
TreeHugger Robot
2020-04-21 22:22:37 +00:00
committed by Android (Google) Code Review
parent bdd4f85bcd 5890360562
commit d907c49479
1 changed files with 19 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
core/java/android/database/sqlite/SQLiteConnection.java
View File

@@ -228,19 +228,26 @@ public final class SQLiteConnection implements CancellationSignal.OnCancelListen
} catch (SQLiteCantOpenDatabaseException e) {
String message = String.format("Cannot open database '%s'", file);
final Path path = FileSystems.getDefault().getPath(file);
final Path dir = path.getParent();
try {
// Try to diagnose for common reasons. If something fails in here, that's fine;
// just swallow the exception.
if (!Files.isDirectory(dir)) {
message += ": Directory " + dir + " doesn't exist";
} else if (!Files.exists(path)) {
message += ": File " + path + " doesn't exist";
} else if (!Files.isReadable(path)) {
message += ": File " + path + " is not readable";
} else if (Files.isDirectory(path)) {
message += ": Path " + path + " is a directory";
} else {
message += ": Unknown reason";
final Path path = FileSystems.getDefault().getPath(file);
final Path dir = path.getParent();
if (!Files.isDirectory(dir)) {
message += ": Directory " + dir + " doesn't exist";
} else if (!Files.exists(path)) {
message += ": File " + path + " doesn't exist";
} else if (!Files.isReadable(path)) {
message += ": File " + path + " is not readable";
} else if (Files.isDirectory(path)) {
message += ": Path " + path + " is a directory";
} else {
message += ": Unknown reason";
}
} catch (Throwable th) {
message += ": Unknown reason; cannot examine filesystem: " + th.getMessage();
}
throw new SQLiteCantOpenDatabaseException(message, e);
} finally {