From 7aa64a78ae6fac532da384599a63278598f4ac6f Mon Sep 17 00:00:00 2001 From: atrost Date: Thu, 29 Aug 2019 14:22:13 +0100 Subject: [PATCH] Remove prefix property from platform_compat_config module It's no longer needed as the configs moved to their own directory. Also CompatConfig now reads from the new location. Bug: 140074769 Bug: 140092095 Test: m, atest FrameworksServicesTests Change-Id: Ia800a63096693717b027c7291dc8005ca1c93fe5 --- Android.bp | 1 - services/Android.bp | 1 - .../java/com/android/server/compat/CompatConfig.java | 10 ++++------ 3 files changed, 4 insertions(+), 8 deletions(-) diff --git a/Android.bp b/Android.bp index b546ebdeda18d..0ad8ebab4a2db 100644 --- a/Android.bp +++ b/Android.bp @@ -340,7 +340,6 @@ java_library { platform_compat_config { name: "framework-platform-compat-config", - prefix: "framework", src: ":framework-annotation-proc", } diff --git a/services/Android.bp b/services/Android.bp index 75fd0129d27a2..771f2a7f58b8f 100644 --- a/services/Android.bp +++ b/services/Android.bp @@ -57,6 +57,5 @@ cc_library_shared { platform_compat_config { name: "services-platform-compat-config", - prefix: "services", src: ":services", } diff --git a/services/core/java/com/android/server/compat/CompatConfig.java b/services/core/java/com/android/server/compat/CompatConfig.java index 044e41789bb2c..027e2fb5ccaa8 100644 --- a/services/core/java/com/android/server/compat/CompatConfig.java +++ b/services/core/java/com/android/server/compat/CompatConfig.java @@ -47,11 +47,10 @@ import javax.xml.datatype.DatatypeConfigurationException; public final class CompatConfig { private static final String TAG = "CompatConfig"; - private static final String CONFIG_FILE_SUFFIX = "platform_compat_config.xml"; private static final CompatConfig sInstance = new CompatConfig().initConfigFromLib( Environment.buildPath( - Environment.getRootDirectory(), "etc", "sysconfig")); + Environment.getRootDirectory(), "etc", "compatconfig")); @GuardedBy("mChanges") private final LongSparseArray mChanges = new LongSparseArray<>(); @@ -212,10 +211,9 @@ public final class CompatConfig { return this; } for (File f : libraryDir.listFiles()) { + Slog.d(TAG, "Found a config file: " + f.getPath()); //TODO(b/138222363): Handle duplicate ids across config files. - if (f.getPath().endsWith(CONFIG_FILE_SUFFIX)) { - readConfig(f); - } + readConfig(f); } return this; } @@ -223,7 +221,7 @@ public final class CompatConfig { private void readConfig(File configFile) { try (InputStream in = new BufferedInputStream(new FileInputStream(configFile))) { for (Change change : XmlParser.read(in).getCompatChange()) { - Slog.w(TAG, "Adding: " + change.toString()); + Slog.d(TAG, "Adding: " + change.toString()); addChange(new CompatChange(change)); } } catch (IOException | DatatypeConfigurationException | XmlPullParserException e) {