From d85d85394ef96489e0848edd72b275798281d779 Mon Sep 17 00:00:00 2001 From: Daniel Nishi Date: Thu, 12 Jan 2017 16:10:57 -0800 Subject: [PATCH] Fix a near instant stats permission check false negative. The MODE_DEFAULT enforcePermission behavior fell through to the switch default case, even if the calling permission was granted. Bug: 34258237 Test: Manual Change-Id: I823fb4dc3657c15eb1fa3d12d4f4c7e1e9e21cd5 --- .../usage/java/com/android/server/usage/StorageStatsService.java | 1 + 1 file changed, 1 insertion(+) diff --git a/services/usage/java/com/android/server/usage/StorageStatsService.java b/services/usage/java/com/android/server/usage/StorageStatsService.java index 512a119927bb6..6ba1f8076008c 100644 --- a/services/usage/java/com/android/server/usage/StorageStatsService.java +++ b/services/usage/java/com/android/server/usage/StorageStatsService.java @@ -86,6 +86,7 @@ public class StorageStatsService extends IStorageStatsManager.Stub { case AppOpsManager.MODE_DEFAULT: mContext.enforceCallingPermission( android.Manifest.permission.PACKAGE_USAGE_STATS, TAG); + return; default: throw new SecurityException("Blocked by mode " + mode); }