From 6acb76621dab874ba21a997e7e375dfe284a843f Mon Sep 17 00:00:00 2001 From: Fan Zhang Date: Mon, 17 Oct 2016 12:40:03 -0700 Subject: [PATCH] Catch NPE on network state and fall back to empty summary. Bug: 32171456 Change-Id: Ia3c1e1f5b7848ec914be9f92401a02b50df1dc57 --- .../src/com/android/settingslib/wifi/AccessPoint.java | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/packages/SettingsLib/src/com/android/settingslib/wifi/AccessPoint.java b/packages/SettingsLib/src/com/android/settingslib/wifi/AccessPoint.java index b63752c225211..234ae712c49e0 100644 --- a/packages/SettingsLib/src/com/android/settingslib/wifi/AccessPoint.java +++ b/packages/SettingsLib/src/com/android/settingslib/wifi/AccessPoint.java @@ -356,7 +356,11 @@ public class AccessPoint implements Comparable { } public DetailedState getDetailedState() { - return mNetworkInfo != null ? mNetworkInfo.getDetailedState() : null; + if (mNetworkInfo != null) { + return mNetworkInfo.getDetailedState(); + } + Log.w(TAG, "NetworkInfo is null, cannot return detailed state"); + return null; } public String getSavedNetworkSummary() { @@ -798,7 +802,10 @@ public class AccessPoint implements Comparable { return context.getString(R.string.wifi_connected_no_internet); } } - + if (state == null) { + Log.w(TAG, "state is null, returning empty summary"); + return ""; + } String[] formats = context.getResources().getStringArray((ssid == null) ? R.array.wifi_status : R.array.wifi_status_with_ssid); int index = state.ordinal();