From 0e6cac26585b04dc9a357b03cab09d93404819f1 Mon Sep 17 00:00:00 2001 From: Jason Monk Date: Wed, 13 May 2015 16:01:16 -0400 Subject: [PATCH] Add default icon for permissions Bug: 21119477 Change-Id: Ie982a1b42d2195ab79c33cf87756efb3bd9eab29 --- core/res/res/drawable/ic_perm_device_info.xml | 24 +++++++++++++++++++ core/res/res/values/symbols.xml | 1 + .../applications/PermissionsInfo.java | 7 +++--- 3 files changed, 29 insertions(+), 3 deletions(-) create mode 100644 core/res/res/drawable/ic_perm_device_info.xml diff --git a/core/res/res/drawable/ic_perm_device_info.xml b/core/res/res/drawable/ic_perm_device_info.xml new file mode 100644 index 0000000000000..ef91c74620ac2 --- /dev/null +++ b/core/res/res/drawable/ic_perm_device_info.xml @@ -0,0 +1,24 @@ + + + + diff --git a/core/res/res/values/symbols.xml b/core/res/res/values/symbols.xml index 8f949e1265f8b..ef42738ecb8c4 100755 --- a/core/res/res/values/symbols.xml +++ b/core/res/res/values/symbols.xml @@ -2262,4 +2262,5 @@ + diff --git a/packages/SettingsLib/src/com/android/settingslib/applications/PermissionsInfo.java b/packages/SettingsLib/src/com/android/settingslib/applications/PermissionsInfo.java index 60b5ba581f5d8..7e68132055243 100644 --- a/packages/SettingsLib/src/com/android/settingslib/applications/PermissionsInfo.java +++ b/packages/SettingsLib/src/com/android/settingslib/applications/PermissionsInfo.java @@ -22,7 +22,6 @@ import android.content.pm.PackageManager.NameNotFoundException; import android.content.pm.PermissionGroupInfo; import android.content.pm.PermissionInfo; import android.graphics.drawable.Drawable; -import android.graphics.drawable.ShapeDrawable; import android.os.AsyncTask; import android.os.Build; import android.os.UserHandle; @@ -80,7 +79,8 @@ public class PermissionsInfo { if (info.protectionLevel == PermissionInfo.PROTECTION_DANGEROUS) { group = new PermissionGroup(); // TODO: Add default permission icon. - group.icon = info.icon != 0 ? info.loadIcon(mPm) : new ShapeDrawable(); + group.icon = info.icon != 0 ? info.loadIcon(mPm) : mContext.getDrawable( + com.android.internal.R.drawable.ic_perm_device_info); group.name = info.name; group.label = info.loadLabel(mPm).toString(); mGroups.add(group); @@ -103,7 +103,8 @@ public class PermissionsInfo { for (PermissionGroupInfo groupInfo : groups) { PermissionGroup group = new PermissionGroup(); // TODO: Add default permission icon. - group.icon = groupInfo.icon != 0 ? groupInfo.loadIcon(mPm) : new ShapeDrawable(); + group.icon = groupInfo.icon != 0 ? groupInfo.loadIcon(mPm) : mContext.getDrawable( + com.android.internal.R.drawable.ic_perm_device_info); group.name = groupInfo.name; group.label = groupInfo.loadLabel(mPm).toString(); synchronized (mGroups) {