From 8fd2f6d2aaa5df6807442952dab577cd54c6181a Mon Sep 17 00:00:00 2001 From: Chiachang Wang Date: Mon, 14 Dec 2020 11:06:02 +0800 Subject: [PATCH] Remove hidden deprecated getActiveNetworkQuotaInfo getActiveNetworkQuotaInfo has never been in API surface since it was introduced. It became essentially functionless since android O, so there should be no usage dependency upon the hidden method, In order to support ConnectivityService mainline, remove the useless function to prevent necessary dependency. Bug: 172183305 Test: atest FrameworksNetTests Change-Id: Ia685b3260256d465ef614b2f577d13344074c787 --- core/java/android/net/ConnectivityManager.java | 11 ----------- core/java/android/net/IConnectivityManager.aidl | 2 -- .../java/com/android/server/ConnectivityService.java | 9 --------- 3 files changed, 22 deletions(-) diff --git a/core/java/android/net/ConnectivityManager.java b/core/java/android/net/ConnectivityManager.java index cf5d4e579f85d..1e968721e6373 100644 --- a/core/java/android/net/ConnectivityManager.java +++ b/core/java/android/net/ConnectivityManager.java @@ -2108,17 +2108,6 @@ public class ConnectivityManager { // ignored } - /** {@hide} */ - @Deprecated - @UnsupportedAppUsage(maxTargetSdk = Build.VERSION_CODES.R, trackingBug = 170729553) - public NetworkQuotaInfo getActiveNetworkQuotaInfo() { - try { - return mService.getActiveNetworkQuotaInfo(); - } catch (RemoteException e) { - throw e.rethrowFromSystemServer(); - } - } - /** * @hide * @deprecated Talk to TelephonyManager directly diff --git a/core/java/android/net/IConnectivityManager.aidl b/core/java/android/net/IConnectivityManager.aidl index 41732008b4ee6..fb01283633107 100644 --- a/core/java/android/net/IConnectivityManager.aidl +++ b/core/java/android/net/IConnectivityManager.aidl @@ -25,7 +25,6 @@ import android.net.Network; import android.net.NetworkAgentConfig; import android.net.NetworkCapabilities; import android.net.NetworkInfo; -import android.net.NetworkQuotaInfo; import android.net.NetworkRequest; import android.net.NetworkState; import android.net.ISocketKeepaliveCallback; @@ -76,7 +75,6 @@ interface IConnectivityManager @UnsupportedAppUsage(maxTargetSdk = 30, trackingBug = 170729553) NetworkState[] getAllNetworkState(); - NetworkQuotaInfo getActiveNetworkQuotaInfo(); boolean isActiveNetworkMetered(); boolean requestRouteToHostAddress(int networkType, in byte[] hostAddress, diff --git a/services/core/java/com/android/server/ConnectivityService.java b/services/core/java/com/android/server/ConnectivityService.java index a42c864744609..f1d0fefd903a3 100644 --- a/services/core/java/com/android/server/ConnectivityService.java +++ b/services/core/java/com/android/server/ConnectivityService.java @@ -113,7 +113,6 @@ import android.net.NetworkInfo.DetailedState; import android.net.NetworkMonitorManager; import android.net.NetworkPolicyManager; import android.net.NetworkProvider; -import android.net.NetworkQuotaInfo; import android.net.NetworkRequest; import android.net.NetworkSpecifier; import android.net.NetworkStack; @@ -1779,14 +1778,6 @@ public class ConnectivityService extends IConnectivityManager.Stub return result.toArray(new NetworkState[result.size()]); } - @Override - @Deprecated - public NetworkQuotaInfo getActiveNetworkQuotaInfo() { - Log.w(TAG, "Shame on UID " + Binder.getCallingUid() - + " for calling the hidden API getNetworkQuotaInfo(). Shame!"); - return new NetworkQuotaInfo(); - } - @Override public boolean isActiveNetworkMetered() { enforceAccessPermission();